Use ObjectFactory.directoryProperty() if possible #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProjectLayout.directoryProperty() was deprecated in Gradle 5.0 and replaced with ObjectFactory.directoryProperty(). In order to stay backward compatible with Gradle 4.x, the latter is now called first and the former is used as a fallback. Resolves ajoberstar#64.
ajoberstar
reviewed
Mar 22, 2019
| public static DirectoryProperty create(ProjectLayout layout, ObjectFactory objectFactory) { | ||
| try { | ||
| return objectFactory.directoryProperty(); | ||
| } catch (NoSuchMethodError e) { |
There was a problem hiding this comment.
We could avoid the exception by using if (GradleVersion.current() < GradleVersion.version('5.0')) or something similar, right?
There was a problem hiding this comment.
Right. Would you prefer that?
There was a problem hiding this comment.
Yeah. If you don't have time, let me know. I plan to make some updates to the plug-in later today.
|
I have a fix released in 2.1.0-beta.1. Thanks for sending this in, nudged me to get some other fixes done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProjectLayout.directoryProperty() was deprecated in Gradle 5.0 and
replaced with ObjectFactory.directoryProperty(). In order to stay
backward compatible with Gradle 4.x, the latter is now called first and
the former is used as a fallback.
Resolves #64.