Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to opt out of gpgsign #78

Closed
britter opened this issue Dec 18, 2019 · 3 comments · Fixed by #80
Closed

Provide a way to opt out of gpgsign #78

britter opened this issue Dec 18, 2019 · 3 comments · Fixed by #80

Comments

@britter
Copy link
Contributor

britter commented Dec 18, 2019

I have commit signing enabled globally in my git config. When using this plugin, the gitPublishCommit task fails with org.eclipse.jgit.api.errors.JGitInternalException: missing credentials provider, because the gpg key I use for signing is password protected (see https://scans.gradle.com/s/hcmyry7guhezc/failure?openFailures=WzBd&openStackTraces=WzJd#top=0). As a work around I have added a task that modified the .git/config file inside the cloned repository and deactivates commit signing there. It would be great to have a configuration option on GitPublishExtension to deactivate commit signing.

@ajoberstar
Copy link
Owner

Yeah, this could be useful to expose. Likely won't get to this myself, but a PR would be welcome. Thanks for submitting this!

@ajoberstar
Copy link
Owner

There is a sign property on the grgit.commit(), if anyone looks at doing this.

@britter
Copy link
Contributor Author

britter commented Jan 1, 2020

Here you go #80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants