Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Injecting credentials no longer seems to work with 5.0.0 #115

Closed
marcphilipp opened this issue Dec 9, 2024 · 4 comments
Closed

Injecting credentials no longer seems to work with 5.0.0 #115

marcphilipp opened this issue Dec 9, 2024 · 4 comments
Labels

Comments

@marcphilipp
Copy link

After removing fetchDepth to work around #114, I'm now running into the next problem:

:gitPublishPush FAILED	
fatal: could not read Username for 'https://github.com/': No such device or address

https://ge.junit.org/s/oouojjedzzoja/console-log/task/:gitPublishPush?anchor=1&page=1

I'm injecting credentials by setting the GRGIT_USER env var. Has anything changed in this regard?

@ajoberstar
Copy link
Owner

Yes, in switching to the Git cli all of the grgit specific authentication options don't work anymore.

Will look into this more later today.

@ajoberstar ajoberstar added the bug label Dec 9, 2024
@marcphilipp
Copy link
Author

That makes sense! It's still documented in the repo's README, though. What's the new recommendation for configuring credentials?

@ajoberstar
Copy link
Owner

I'll remove that mention from the README. Since it all happened implicitly via grgit before, it slipped my mind to come up with an alternative in the cli impl.

Guessing I'll need to add a credentials {} block into the publication so that people can choose how to retrieve their creds as best suits them.

ajoberstar added a commit that referenced this issue Dec 10, 2024
@ajoberstar
Copy link
Owner

ajoberstar commented Dec 10, 2024

Added username and password properties to GitPublication. If they're both set, they'll get passed to the relevant commands via a credential helper.

Will be in 5.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants