Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native e.detail click count in event.addMultiMouseDownListener #1225

Closed
wants to merge 1 commit into from

Conversation

danyaPostfactum
Copy link
Contributor

Fixes #978 in non-gecko browsers .
WebKit need this to support native d'n'd properly.

@nightwing
Copy link
Member

    if (e.detail > 1) {
        clicks++
        if (clicks > 4)
             clicks = 1
     } else {
           clicks = 1                
     }

seems to work relatively well for all browsers, but quad and triple click timeouts are wrong, i think they must be shorter than double click

@danyaPostfactum
Copy link
Contributor Author

They are shorter in Firefox implementation. But all windows apps I tested have the same timeout for all clicks in a row. Opera ignores system setting and uses it's own timeout.

@danyaPostfactum
Copy link
Contributor Author

So, can it be merged? I'm updating my native dnd branch.

@nightwing
Copy link
Member

I'm updating my native dnd branch.

Cool! Looking forward to that.

I am not really sure about this, 4-click timing feels too off, but maybe i am unnecessarily picky about it.
Can you include this in dnd branch? Then it will be easier to decide what to do. use this or search for another workaround.

@nightwing
Copy link
Member

closing since this is included in #1431

@nightwing nightwing closed this May 17, 2013
@danyaPostfactum
Copy link
Contributor Author

There is the issue in IE. It does not take into account distance between click locations. I file the bug here.

@nightwing
Copy link
Member

Funny, now they do not take into account even the time between clicks #1751 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACE does not respect double click speed, set in operating system settings (Windows)
2 participants