Add a detection sample #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajalt
requested changes
Sep 18, 2023
| @@ -4,13 +4,13 @@ import com.github.ajalt.mordant.internal.* | |||
| import com.github.ajalt.mordant.rendering.AnsiLevel | |||
| import com.github.ajalt.mordant.rendering.AnsiLevel.* | |||
|
|
|||
| internal object TerminalDetection { | |||
| object TerminalDetection { | |||
There was a problem hiding this comment.
I don't think there's any reason to make this public. Instead of TerminalDetection.detectTerminal(), folks can can the same object from Terminal().info.
There was a problem hiding this comment.
Thanks for pointing out Terminal().info, that's much nicer, and I've dropped this commit from the PR.
| /** The terminal width, in cells */ | ||
| width: Int, | ||
| var width: Int, |
There was a problem hiding this comment.
This is a change in API, but I don't see any harm in it, and I like using the data class for toString.
|
|
||
| fun main() { | ||
| val terminal = Terminal() | ||
| terminal.println(TerminalDetection.detectTerminal()) |
There was a problem hiding this comment.
Suggested change
| terminal.println(TerminalDetection.detectTerminal()) | |
| terminal.println(terminal.info) |
This allows to easily compare instances and benefit from an auto-generated `toString()` representation. The downside is that `width` and `height` could now be set from the outside after construction, but that is probably not too much of an issue as arbitrary values could also have been passed via the constructor initially anyway.
sschuberth
force-pushed
the
detection
branch
from
2ab2f46 to
254d2a4
Compare
sschuberth
force-pushed
the
detection
branch
from
254d2a4 to
046ad77
Compare
Later on printing of selected environment variables or similar useful output could be added.
sschuberth
force-pushed
the
detection
branch
from
046ad77 to
8b43936
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.