Implement fix for noUnnecessaryElseRule #103
Conversation
There was a problem hiding this comment.
Thank you for submitting this PR.
I left some comments regarding the implementation.
Incidentally the thing with block-scoped variables in the else-block is also discussed and fixed in eslint/eslint#11076
The test need to be updated for the changed error output (see failed CI of this PR). Also please add a .fix file next to the .lint file to ensure the fixes work as expected.
eile
force-pushed
the
master
branch
2 times, most recently
from
0450bb4 to
8b05c1a
Compare
|
I've decided to remove the stripping of the else block, since I couldn't figure out a way to do this sanely in a single fix. It almost feels like it should be a separate no-unneccassary-block rule with fixer. |
|
Just saw your comments, reading now.. |
|
Ah, much better now. Thanks for the explanations. |
rules/noUnnecessaryElseRule.ts
Outdated
| return ts.forEachChild(sourceFile, cb); | ||
| } | ||
|
|
||
| /** Return true to traverse children, false otherwise */ |
rules/noUnnecessaryElseRule.ts
Outdated
| } | ||
| } | ||
|
|
||
| class IfWalker extends Lint.AbstractWalker<void> { |
There was a problem hiding this comment.
could be reverted to extend AbstractIfStatementWalker. you can then drop the implementation of walk
|
And it's published as |
No description provided.