Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service): mark service connection info sensitive #1697

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

byashimov
Copy link
Contributor

@byashimov byashimov commented Apr 19, 2024

Marks all connection info blocks as sensitive because terraform hides sensitive data within nested blocks. See hashicorp/terraform-plugin-sdk#201

@byashimov
Copy link
Contributor Author

tests

@byashimov
Copy link
Contributor Author

The whole block is hidden:

~ kafka                   = (sensitive value)

@byashimov byashimov marked this pull request as ready for review April 19, 2024 13:17
@byashimov byashimov requested a review from a team as a code owner April 19, 2024 13:17
@byashimov byashimov force-pushed the byashimov-fix-connection-info-plan-output branch from 7c37e2a to 171589b Compare April 19, 2024 13:18
@Serpentiel Serpentiel self-assigned this Apr 19, 2024
@Serpentiel Serpentiel added the bug Something isn't working label Apr 19, 2024
Copy link
Contributor

@Serpentiel Serpentiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Serpentiel Serpentiel enabled auto-merge (squash) April 19, 2024 13:24
@Serpentiel Serpentiel merged commit d5e542f into main Apr 19, 2024
32 of 100 checks passed
@Serpentiel Serpentiel deleted the byashimov-fix-connection-info-plan-output branch April 19, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants