Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(charts): install in kind #361

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Conversation

byashimov
Copy link
Contributor

@byashimov byashimov commented Apr 13, 2023

Please, see attached docs.

@byashimov byashimov force-pushed the byashimov-install-in-kind branch from 44adeae to 959e79d Compare April 13, 2023 16:57
@byashimov byashimov marked this pull request as ready for review April 13, 2023 16:58
@byashimov byashimov requested a review from a team April 13, 2023 16:58
@byashimov byashimov force-pushed the byashimov-install-in-kind branch from 959e79d to ef70231 Compare April 14, 2023 06:21
@byashimov byashimov marked this pull request as draft April 14, 2023 07:45
@byashimov byashimov force-pushed the byashimov-install-in-kind branch from ef70231 to 67cc7be Compare April 14, 2023 08:16
@byashimov
Copy link
Contributor Author

byashimov commented Apr 14, 2023

Updated to setup webhooks:

✗ kubectl apply -f postgresql.yaml
postgresql.aiven.io/my-postgresql configured
✗ kubectl delete -f postgresql.yaml
Error from server (cannot delete PostgreSQL service, termination protection is on): error when deleting "postgresql.yaml": admission webhook "vpg.kb.io" denied the request: cannot delete PostgreSQL service, termination protection is on
✗ kubectl apply -f postgresql.yaml 
postgresql.aiven.io/my-postgresql configured
✗ kubectl delete -f postgresql.yaml
postgresql.aiven.io "my-postgresql" deleted

@byashimov byashimov marked this pull request as ready for review April 14, 2023 08:18
Copy link
Contributor

@ivan-savciuc ivan-savciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails on my box

docs/docs/contributing/developer-guide.md Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@byashimov byashimov force-pushed the byashimov-install-in-kind branch from 67cc7be to 4e61690 Compare April 14, 2023 08:46
@byashimov byashimov requested a review from ivan-savciuc April 14, 2023 08:53
@byashimov byashimov force-pushed the byashimov-install-in-kind branch from 4e61690 to 62e97ab Compare April 14, 2023 08:56
@byashimov byashimov force-pushed the byashimov-install-in-kind branch from 62e97ab to 40ebb46 Compare April 14, 2023 10:39
@byashimov byashimov requested a review from ivan-savciuc April 14, 2023 10:41
Makefile Show resolved Hide resolved
@Serpentiel Serpentiel added the enhancement New feature or request label Apr 18, 2023
@Serpentiel Serpentiel force-pushed the byashimov-install-in-kind branch from 40ebb46 to 41a2ea8 Compare April 18, 2023 07:59
@Serpentiel
Copy link
Contributor

Serpentiel commented Apr 18, 2023

is the chore commit type good enough here? perhaps we can use something like build(e2e): install in kind? @byashimov wdyt?

@byashimov byashimov force-pushed the byashimov-install-in-kind branch from 41a2ea8 to d0828b7 Compare April 20, 2023 07:05
@byashimov byashimov changed the title chore(kind): install in kind test(kind): install in kind Apr 20, 2023
@byashimov byashimov force-pushed the byashimov-install-in-kind branch from d0828b7 to 38eb6a6 Compare April 20, 2023 07:05
@byashimov byashimov changed the title test(kind): install in kind test(charts): install in kind Apr 20, 2023
@byashimov byashimov force-pushed the byashimov-install-in-kind branch from 38eb6a6 to 9fb0fc2 Compare April 20, 2023 09:59
@byashimov byashimov force-pushed the byashimov-install-in-kind branch from 9fb0fc2 to e63f290 Compare April 20, 2023 10:03
Copy link
Contributor

@ivan-savciuc ivan-savciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fails on my machine, but it seems to be a general podman flakiness

@ivan-savciuc ivan-savciuc merged commit f03b56a into main Apr 20, 2023
@ivan-savciuc ivan-savciuc deleted the byashimov-install-in-kind branch April 20, 2023 12:02
@Serpentiel
Copy link
Contributor

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants