Fixed bugs when running aiaccel in local mode on Windows #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
3bisuoka
commented
Jun 3, 2024
3bisuoka
commented
- added if statement wrt Windows in process.py and local_model.py.
- added the optional argument, shell=True, to subprocess.Popen().
- added select_for_win() as the alternative to select.select() because it is not available on Windows.
- fixed descriptions wrt Windows in docs.
* added select_for_win() in process.py. * fixed Popen in local_model.py. * fixed descriptions wrt Windows in docs.
3bisuoka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.