Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update readme #25

Merged
merged 3 commits into from
Aug 5, 2022
Merged

Feature/update readme #25

merged 3 commits into from
Aug 5, 2022

Conversation

KanaiYuma-aist
Copy link
Collaborator

Reflect issue #24

  • both README.md and README_JP.md

    • Use venv instead of virtualenv
    • Add module load gcc before module load python/3.8/3.8.13
    • Add > to some commands that don't have > in top
    • Correct "Steps 1 to 2" instead of "Steps 1 to 4" because it is unnecesary for preparing the workspace that "3. Run the parameter optimization" and "4. Wait for the program to finish and check the optimization results."
  • README.md

    • Update the "--clean" option description
      • start -> start after cleaning
    • correct the link to ABCI user guide from Japanese to English.
    • "The other processes are same with sphere tutorial on local computer from 6 to 10." is unneccesary
    • Some space for command don't have bash
  • README_JP.md

    • Steps 2 and 3 in "Running on ABCI" are reversed.

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

Unit Test Results

238 tests  ±0   238 ✔️ ±0   37s ⏱️ +4s
    1 suites ±0       0 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 5435dd2. ± Comparison against base commit da21de6.

♻️ This comment has been updated with latest results.

@KanaiYuma-aist KanaiYuma-aist added the documentation Improvements or additions to documentation label Aug 3, 2022
@aramoto99 aramoto99 merged commit f243f92 into main Aug 5, 2022
@aramoto99 aramoto99 deleted the feature/update_README branch August 5, 2022 00:45
yoshipon added a commit that referenced this pull request Aug 5, 2022
* Fix #19 (#20)

* Fix #21 (#22)

* fix README (#23)

* fix codestyle test (#26)

* fix for pycodestyle

* add flake8==4.0.1

* Feature/update readme (#25)

* update README

* add bash

Co-authored-by: Yoshiaki Bando <[email protected]>

* Fix resumption test for DB

Co-authored-by: Takashi OKADA <[email protected]>
Co-authored-by: KanaiYuma-aist <[email protected]>
Co-authored-by: Yoshiaki Bando <[email protected]>
yoshipon added a commit that referenced this pull request Aug 26, 2022
* Fix #19 (#20)

* Fix #21 (#22)

* fix README (#23)

* fix codestyle test (#26)

* fix for pycodestyle

* add flake8==4.0.1

* Feature/update readme (#25)

* update README

* add bash

Co-authored-by: Yoshiaki Bando <[email protected]>

* Fix TPE resumtion test (#29)

* Fix tpe resumption test

* fix tpe resumption test

* Fix tep resumption test

* add retry (#38)

* Add dynamic loading of optimizer (#34)

* (WIP) Add dynamic loading of optimizer by importlib.

* (WIP) Add dynamic loading of optimizer by importlib.

* Add dynamic loading of optimizer by importlib

* Add dynamic loading of optimizer by importlib

* Fix test code

* fix test

* Fix resumtioin test

* Add dynamic loading of optimizer

* Fix dynamic loading of optimizer

* Function names and comments were rolled back.

* Changed the standard optimizer specification method

* changed the specification method for importing the standard optimizer.

* change deserialize (#40)

Co-authored-by: aramoto99 <[email protected]>

* Merge branch 'main' of github:aistairc/aiaccel into feature/database

* Fix codestyle

* (WIP) Change TPE resume

* Fix resume test

* Feature/fix resume tpe (#41)

* fix resume tpe

* fix resume tpe

* add if len(running_trials) > 0

* fix about trial number

* Fix TPE resumption

Co-authored-by: Takashi OKADA <[email protected]>
Co-authored-by: KanaiYuma-aist <[email protected]>
Co-authored-by: Yoshiaki Bando <[email protected]>
yoshipon added a commit that referenced this pull request Aug 26, 2022
* Fix #19 (#20)

* Fix #21 (#22)

* fix README (#23)

* fix codestyle test (#26)

* fix for pycodestyle

* add flake8==4.0.1

* Feature/update readme (#25)

* update README

* add bash

Co-authored-by: Yoshiaki Bando <[email protected]>

* Fix TPE resumtion test (#29)

* Fix tpe resumption test

* fix tpe resumption test

* Fix tep resumption test

* add retry (#38)

* Add dynamic loading of optimizer (#34)

* (WIP) Add dynamic loading of optimizer by importlib.

* (WIP) Add dynamic loading of optimizer by importlib.

* Add dynamic loading of optimizer by importlib

* Add dynamic loading of optimizer by importlib

* Fix test code

* fix test

* Fix resumtioin test

* Add dynamic loading of optimizer

* Fix dynamic loading of optimizer

* Function names and comments were rolled back.

* Changed the standard optimizer specification method

* changed the specification method for importing the standard optimizer.

* change deserialize (#40)

Co-authored-by: aramoto99 <[email protected]>

* Merge branch 'main' of github:aistairc/aiaccel into feature/database

* Fix codestyle

* (WIP) Change TPE resume

* Fix resume test

* Feature/fix resume tpe (#41)

* fix resume tpe

* fix resume tpe

* add if len(running_trials) > 0

* fix about trial number

* Fix TPE resumption

Co-authored-by: Takashi OKADA <[email protected]>
Co-authored-by: KanaiYuma-aist <[email protected]>
Co-authored-by: Yoshiaki Bando <[email protected]>
yoshipon added a commit that referenced this pull request Aug 30, 2022
* Data management function by database is added.
By adding the `--fs` option argument to the startup command, data management functions by the conventional file system can be used.
Extensive refactoring was performed around the addition of this functionality.

* Update setup.py

* Delete tests/test_data/work/state/ as it is not used in develop/database.

* Develop/database fix test (#18)

* fix for tests

* delete space

* pInfoDict -> p_info

* Merge main into debelop/database (#31)

* Fix #19 (#20)

* Fix #21 (#22)

* fix README (#23)

* fix codestyle test (#26)

* fix for pycodestyle

* add flake8==4.0.1

* Feature/update readme (#25)

* update README

* add bash

Co-authored-by: Yoshiaki Bando <[email protected]>

* Fix resumption test for DB

Co-authored-by: Takashi OKADA <[email protected]>
Co-authored-by: KanaiYuma-aist <[email protected]>
Co-authored-by: Yoshiaki Bando <[email protected]>

* Feature/database (#36)

* Fix #19 (#20)

* Fix #21 (#22)

* fix README (#23)

* Fixed a problem in which Snapshot could not be saved during parallel execution.

* Add function of delete any data in DB/FS.

* Fix code style

Co-authored-by: Takashi OKADA <[email protected]>
Co-authored-by: KanaiYuma-aist <[email protected]>

* Request to merge cumulative changes . (#37)

* Fix #19 (#20)

* Fix #21 (#22)

* fix README (#23)

* The report generation function can now be called by command.

* Fix data inconsistency when excute resume. (#39)

* Fix resume

* Fixed problem with sirialize not working in fs mode

* Remove unused package imports

* Fixed a problem that the resume function did not work in fs mode.

* The name workspace/state is the name of the old specification, so it was changed to the appropriate name workspace/snapshot.

* Delete unnecessary directories in Workspace.

* Delete unnecessary directories in Workspace.

* Delete unnecessary directories in Workspace.

* Delete unnecessary directories in Workspace.

Co-authored-by: Takashi OKADA <[email protected]>
Co-authored-by: KanaiYuma-aist <[email protected]>

* Add dynamic loading of optimizer, And fix resumtion test. (#42)

* Fix #19 (#20)

* Fix #21 (#22)

* fix README (#23)

* fix codestyle test (#26)

* fix for pycodestyle

* add flake8==4.0.1

* Feature/update readme (#25)

* update README

* add bash

Co-authored-by: Yoshiaki Bando <[email protected]>

* Fix TPE resumtion test (#29)

* Fix tpe resumption test

* fix tpe resumption test

* Fix tep resumption test

* add retry (#38)

* Add dynamic loading of optimizer (#34)

* (WIP) Add dynamic loading of optimizer by importlib.

* (WIP) Add dynamic loading of optimizer by importlib.

* Add dynamic loading of optimizer by importlib

* Add dynamic loading of optimizer by importlib

* Fix test code

* fix test

* Fix resumtioin test

* Add dynamic loading of optimizer

* Fix dynamic loading of optimizer

* Function names and comments were rolled back.

* Changed the standard optimizer specification method

* changed the specification method for importing the standard optimizer.

* change deserialize (#40)

Co-authored-by: aramoto99 <[email protected]>

* Merge branch 'main' of github:aistairc/aiaccel into feature/database

* Fix codestyle

* (WIP) Change TPE resume

* Fix resume test

* Feature/fix resume tpe (#41)

* fix resume tpe

* fix resume tpe

* add if len(running_trials) > 0

* fix about trial number

* Fix TPE resumption

Co-authored-by: Takashi OKADA <[email protected]>
Co-authored-by: KanaiYuma-aist <[email protected]>
Co-authored-by: Yoshiaki Bando <[email protected]>

* Fix conflicts with main branch (#43)

* Fix #19 (#20)

* Fix #21 (#22)

* fix README (#23)

* fix codestyle test (#26)

* fix for pycodestyle

* add flake8==4.0.1

* Feature/update readme (#25)

* update README

* add bash

Co-authored-by: Yoshiaki Bando <[email protected]>

* Fix TPE resumtion test (#29)

* Fix tpe resumption test

* fix tpe resumption test

* Fix tep resumption test

* add retry (#38)

* Add dynamic loading of optimizer (#34)

* (WIP) Add dynamic loading of optimizer by importlib.

* (WIP) Add dynamic loading of optimizer by importlib.

* Add dynamic loading of optimizer by importlib

* Add dynamic loading of optimizer by importlib

* Fix test code

* fix test

* Fix resumtioin test

* Add dynamic loading of optimizer

* Fix dynamic loading of optimizer

* Function names and comments were rolled back.

* Changed the standard optimizer specification method

* changed the specification method for importing the standard optimizer.

* change deserialize (#40)

Co-authored-by: aramoto99 <[email protected]>

* Merge branch 'main' of github:aistairc/aiaccel into feature/database

* Fix codestyle

* (WIP) Change TPE resume

* Fix resume test

* Feature/fix resume tpe (#41)

* fix resume tpe

* fix resume tpe

* add if len(running_trials) > 0

* fix about trial number

* Fix TPE resumption

Co-authored-by: Takashi OKADA <[email protected]>
Co-authored-by: KanaiYuma-aist <[email protected]>
Co-authored-by: Yoshiaki Bando <[email protected]>

* Fix codestyle

Co-authored-by: KanaiYuma-aist <[email protected]>
Co-authored-by: Takashi OKADA <[email protected]>
Co-authored-by: Yoshiaki Bando <[email protected]>
aramoto99 added a commit that referenced this pull request Aug 30, 2022
* Data management function by database is added.
By adding the `--fs` option argument to the startup command, data management functions by the conventional file system can be used.
Extensive refactoring was performed around the addition of this functionality.

* Update setup.py

* Delete tests/test_data/work/state/ as it is not used in develop/database.

* Develop/database fix test (#18)

* fix for tests

* delete space

* pInfoDict -> p_info

* Merge main into debelop/database (#31)

* Fix #19 (#20)

* Fix #21 (#22)

* fix README (#23)

* fix codestyle test (#26)

* fix for pycodestyle

* add flake8==4.0.1

* Feature/update readme (#25)

* update README

* add bash

Co-authored-by: Yoshiaki Bando <[email protected]>

* Fix resumption test for DB

Co-authored-by: Takashi OKADA <[email protected]>
Co-authored-by: KanaiYuma-aist <[email protected]>
Co-authored-by: Yoshiaki Bando <[email protected]>

* Feature/database (#36)

* Fix #19 (#20)

* Fix #21 (#22)

* fix README (#23)

* Fixed a problem in which Snapshot could not be saved during parallel execution.

* Add function of delete any data in DB/FS.

* Fix code style

Co-authored-by: Takashi OKADA <[email protected]>
Co-authored-by: KanaiYuma-aist <[email protected]>

* Request to merge cumulative changes . (#37)

* Fix #19 (#20)

* Fix #21 (#22)

* fix README (#23)

* The report generation function can now be called by command.

* Fix data inconsistency when excute resume. (#39)

* Fix resume

* Fixed problem with sirialize not working in fs mode

* Remove unused package imports

* Fixed a problem that the resume function did not work in fs mode.

* The name workspace/state is the name of the old specification, so it was changed to the appropriate name workspace/snapshot.

* Delete unnecessary directories in Workspace.

* Delete unnecessary directories in Workspace.

* Delete unnecessary directories in Workspace.

* Delete unnecessary directories in Workspace.

Co-authored-by: Takashi OKADA <[email protected]>
Co-authored-by: KanaiYuma-aist <[email protected]>

* Add dynamic loading of optimizer, And fix resumtion test. (#42)

* Fix #19 (#20)

* Fix #21 (#22)

* fix README (#23)

* fix codestyle test (#26)

* fix for pycodestyle

* add flake8==4.0.1

* Feature/update readme (#25)

* update README

* add bash

Co-authored-by: Yoshiaki Bando <[email protected]>

* Fix TPE resumtion test (#29)

* Fix tpe resumption test

* fix tpe resumption test

* Fix tep resumption test

* add retry (#38)

* Add dynamic loading of optimizer (#34)

* (WIP) Add dynamic loading of optimizer by importlib.

* (WIP) Add dynamic loading of optimizer by importlib.

* Add dynamic loading of optimizer by importlib

* Add dynamic loading of optimizer by importlib

* Fix test code

* fix test

* Fix resumtioin test

* Add dynamic loading of optimizer

* Fix dynamic loading of optimizer

* Function names and comments were rolled back.

* Changed the standard optimizer specification method

* changed the specification method for importing the standard optimizer.

* change deserialize (#40)

Co-authored-by: aramoto99 <[email protected]>

* Merge branch 'main' of github:aistairc/aiaccel into feature/database

* Fix codestyle

* (WIP) Change TPE resume

* Fix resume test

* Feature/fix resume tpe (#41)

* fix resume tpe

* fix resume tpe

* add if len(running_trials) > 0

* fix about trial number

* Fix TPE resumption

Co-authored-by: Takashi OKADA <[email protected]>
Co-authored-by: KanaiYuma-aist <[email protected]>
Co-authored-by: Yoshiaki Bando <[email protected]>

* Fix conflicts with main branch (#43)

* Fix #19 (#20)

* Fix #21 (#22)

* fix README (#23)

* fix codestyle test (#26)

* fix for pycodestyle

* add flake8==4.0.1

* Feature/update readme (#25)

* update README

* add bash

Co-authored-by: Yoshiaki Bando <[email protected]>

* Fix TPE resumtion test (#29)

* Fix tpe resumption test

* fix tpe resumption test

* Fix tep resumption test

* add retry (#38)

* Add dynamic loading of optimizer (#34)

* (WIP) Add dynamic loading of optimizer by importlib.

* (WIP) Add dynamic loading of optimizer by importlib.

* Add dynamic loading of optimizer by importlib

* Add dynamic loading of optimizer by importlib

* Fix test code

* fix test

* Fix resumtioin test

* Add dynamic loading of optimizer

* Fix dynamic loading of optimizer

* Function names and comments were rolled back.

* Changed the standard optimizer specification method

* changed the specification method for importing the standard optimizer.

* change deserialize (#40)

Co-authored-by: aramoto99 <[email protected]>

* Merge branch 'main' of github:aistairc/aiaccel into feature/database

* Fix codestyle

* (WIP) Change TPE resume

* Fix resume test

* Feature/fix resume tpe (#41)

* fix resume tpe

* fix resume tpe

* add if len(running_trials) > 0

* fix about trial number

* Fix TPE resumption

Co-authored-by: Takashi OKADA <[email protected]>
Co-authored-by: KanaiYuma-aist <[email protected]>
Co-authored-by: Yoshiaki Bando <[email protected]>

* change serialize timing

Co-authored-by: aramoto99 <[email protected]>
Co-authored-by: aramoto99 <[email protected]>
Co-authored-by: Takashi OKADA <[email protected]>
Co-authored-by: Yoshiaki Bando <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants