Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving on HttpAssetLoader #49

Merged
merged 26 commits into from
Oct 30, 2023
Merged

Improving on HttpAssetLoader #49

merged 26 commits into from
Oct 30, 2023

Conversation

le-vlad
Copy link
Contributor

@le-vlad le-vlad commented May 19, 2023

This PR adds the following:

  • Fixes bug when using HttpAssetLoader for Cyrillic translations.
  • Allows downloading individual translations from the remote host. Similar to the default asset loader
  • Adds a small explanation on how to deal with HttpAssetLoader

@bw-flagship
Copy link
Collaborator

@le-vlad approval is ready, we can merge if you resolve the conflicts :)

@le-vlad
Copy link
Contributor Author

le-vlad commented Oct 26, 2023

Hey @bw-flagship
It's been a while 😄 , but thanks for approving. I'm going to resolve the conflicts today and merge the PR.
Does that sound ok?

@bw-flagship
Copy link
Collaborator

Hey @bw-flagship It's been a while 😄 , but thanks for approving. I'm going to resolve the conflicts today and merge the PR. Does that sound ok?

:D Yes, sorry for the late review. Sounds great!

@le-vlad
Copy link
Contributor Author

le-vlad commented Oct 29, 2023

@bw-flagship Hey! Conflicts were resolved. But we still waiting for the review from @Overman775

@bw-flagship
Copy link
Collaborator

I think we don't need the review from @Overman775 specifically, so let's merge. He still can intervene later if he reviews it :)

@bw-flagship bw-flagship merged commit f432cbf into aissat:master Oct 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants