Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

エラー型を追加 #323

Merged
merged 7 commits into from
Sep 9, 2023
Merged

エラー型を追加 #323

merged 7 commits into from
Sep 9, 2023

Conversation

FineArchs
Copy link
Member

What

新しくエラー型を追加し、試験的にJson:parseに導入します。
#304 を受けて、ひとまずnameinfoのprimitive-propsを持つだけのシンプルな型にしました。

Why

AiScriptの実行を停止せずに関数の実行が失敗したことを知らせる手段を作るため。

Additional info (optional)

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.20% 🎉

Comparison is base (0fa244f) 87.84% compared to head (1fed033) 88.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
+ Coverage   87.84%   88.05%   +0.20%     
==========================================
  Files          20       20              
  Lines        3292     3314      +22     
  Branches      537      541       +4     
==========================================
+ Hits         2892     2918      +26     
+ Misses        389      385       -4     
  Partials       11       11              
Files Changed Coverage Δ
src/interpreter/lib/std.ts 75.17% <100.00%> (+0.17%) ⬆️
src/interpreter/primitive-props.ts 97.11% <100.00%> (+0.07%) ⬆️
src/interpreter/value.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FineArchs
Copy link
Member Author

コンフリクトの解決を行いました。

@FineArchs FineArchs requested a review from syuilo September 9, 2023 06:50
@syuilo syuilo merged commit 87fe3d0 into aiscript-dev:master Sep 9, 2023
4 checks passed
@syuilo
Copy link
Collaborator

syuilo commented Sep 9, 2023

👍

@FineArchs FineArchs deleted the err_type branch September 9, 2023 08:27
FineArchs added a commit to FineArchs-org/aiscript that referenced this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants