Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove log which is causing security issue #348

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

kumaranvpl
Copy link
Collaborator

Description

Type of change

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • I have included code examples to illustrate the modifications

@kumaranvpl kumaranvpl requested a review from davorrunje October 8, 2024 14:12
@kumaranvpl kumaranvpl linked an issue Oct 8, 2024 that may be closed by this pull request
1 task
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
fastagency/adapters/fastapi/base.py 19.56% <ø> (ø)

@kumaranvpl kumaranvpl added this pull request to the merge queue Oct 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 8, 2024
@davorrunje davorrunje added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit f5cecba Oct 8, 2024
22 checks passed
@davorrunje davorrunje deleted the fix-logger-info branch October 8, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix code scanning alert - Clear-text logging of sensitive information
2 participants