Add page load timeouts to web tests #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to merge, this one should be OK. |
mdboom
added a commit
that referenced
this pull request
Jul 27, 2015
Add page load timeouts to web tests
nicolaslecrique
added a commit
to gator-life/gator.life
that referenced
this pull request
Jun 29, 2016
We get random timeouts in Travis on actions on selenium/phantomJS This seems to be a problem specific to Docker/phantomJS mix. More details in the issue below. Retry is the approch of the Pull below. We apply it to get pages and click links (where I spotted the issues) I don't know why we did not get those issues before Flask migration... problem timeout in tavis travis-ci/travis-ci#3251 airspeed-velocity/asv#290
nicolaslecrique
added a commit
to gator-life/gator.life
that referenced
this pull request
Jul 30, 2016
We get random timeouts in Travis on actions on selenium/phantomJS This seems to be a problem specific to Docker/phantomJS mix. More details in the issue below. Retry is the approch of the Pull below. We apply it to get pages and click links (where I spotted the issues) I don't know why we did not get those issues before Flask migration... problem timeout in tavis travis-ci/travis-ci#3251 airspeed-velocity/asv#290
nicolaslecrique
added a commit
to gator-life/gator.life
that referenced
this pull request
Aug 3, 2016
We get random timeouts in Travis on actions on selenium/phantomJS This seems to be a problem specific to Docker/phantomJS mix. More details in the issue below. Retry is the approch of the Pull below. We apply it to get pages and click links (where I spotted the issues) I don't know why we did not get those issues before Flask migration... problem timeout in tavis travis-ci/travis-ci#3251 airspeed-velocity/asv#290
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some googling shows other people are having similar problems:
https://www.google.fi/search?q=selenium+hang+travis
This one contains a potential solution --- set up timeouts, and just retry on failure: https://stackoverflow.com/questions/29108260/geb-selenium-tests-hang-loading-new-page
Related to gh-287
EDIT: also avoid shutting down the preview web server in a way that can block. I managed to reproduce a hang at this point, so best to do this defensively. I'm not sure, but perhaps phantomjs kept connections alive sometimes and prevented the server from shutting down; at the same time, the main process cannot send new instructions to phantomjs because it's waiting for the http server to exit -> deadlock (until socket timeout)?