Merge pull request elastic#8563 from elastic/jasper/backport/8558/5.x

[backport] PR elastic#8558 to 5.x - Remove unused vars Former-commit-id: ec2f4a4
airow · Oct 6, 2016 · ed012f2 · ed012f2
2 parents 4fc7b2d + 0ca9b6f
commit ed012f2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/test/functional/apps/visualize/_line_chart.js b/test/functional/apps/visualize/_line_chart.js
@@ -62,7 +62,7 @@ bdd.describe('visualize app', function describeIndexTests() {
       // sleep a bit before trying to get the chart data
       return PageObjects.common.sleep(3000)
       .then(function () {
-        return PageObjects.visualize.getLineChartData('fill="#57c17b"')
+        return PageObjects.visualize.getLineChartData('fill="#6eadc1"')
         .then(function showData(data) {
           PageObjects.common.debug('data=' + data);
           PageObjects.common.saveScreenshot('Visualize-line-chart');
@@ -92,7 +92,7 @@ bdd.describe('visualize app', function describeIndexTests() {
       })
       .then(function () {
         return PageObjects.common.try(function () {
-          return PageObjects.visualize.getLineChartData('fill="#57c17b"')
+          return PageObjects.visualize.getLineChartData('fill="#6eadc1"')
           .then(function showData(data) {
             PageObjects.common.debug('data=' + data);
             PageObjects.common.saveScreenshot('Visualize-line-chart');

diff --git a/test/support/page_objects/visualize_page.js b/test/support/page_objects/visualize_page.js
@@ -75,7 +75,7 @@ export default class VisualizePage {
   }
 
   getChartTypes() {
-    var types = [];
+
     return this.remote
     .setFindTimeout(defaultFindTimeout)
     .findAllByCssSelector('.wizard-type-heading h4')
@@ -440,7 +440,6 @@ export default class VisualizePage {
     var chartData = [];
     var tempArray = [];
     var chartSections = 0;
-    var chartMap = {};
     var height = 0;
     var yAxisLabel = 0;
     var yAxisHeight = 0;
@@ -529,7 +528,7 @@ export default class VisualizePage {
           // 5). for each chart element, find the green circle, then the cy position
           function getChartType(chart) {
             return chart
-            .findByCssSelector('circle[fill="#6eadc1"]')
+            .findByCssSelector(`circle[${cssPart}]`)
             .then(function (circleObject) {
               // PageObjects.common.debug('circleObject = ' + circleObject + ' yAxisHeight= ' + yAxisHeight + ' yAxisLabel= ' + yAxisLabel);
               return circleObject
@@ -619,8 +618,6 @@ export default class VisualizePage {
   }
 
   getPieChartData() {
-    var self = this.remote;
-
     // 1). get the maximim chart Y-Axis marker value
     return this.remote
     .setFindTimeout(defaultFindTimeout * 2)