Skip to content

Commit

Permalink
fix issue with hiding loading message in embedded mode (elastic#9236)
Browse files Browse the repository at this point in the history
Backports PR elastic#9235

**Commit 1:**
fix issue with hiding loading message in embedded mode

* Original sha: a5d4aaa
* Authored by Stacey Gammon <[email protected]> on 2016-11-28T19:06:49Z

**Commit 2:**
Fix match as well

This chunk of logic only matched on =embed, not =embed=true, which is
what the url given by sharing uses.

* Original sha: 1f6d7d9
* Authored by Stacey Gammon <[email protected]> on 2016-11-28T20:51:20Z

Former-commit-id: fae9380
  • Loading branch information
elastic-jasper authored and stacey-gammon committed Nov 28, 2016
1 parent 675470c commit bb8564a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/ui/views/ui_app.jade
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,9 @@ block content
script.
window.onload = function () {

var hideLoadingMessage = /#.*[?&]embed(&|$)/.test(window.location.href);
var hideLoadingMessage = /#.*[?&]embed(&|$|=true)/.test(window.location.href);
if (hideLoadingMessage) {
var loading = document.querySelector('.ui-app-loading h1');
var loading = document.querySelector('.kibanaWelcomeView');
loading.removeChild(loading.lastChild);
}

Expand Down

0 comments on commit bb8564a

Please sign in to comment.