Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump com.google.errorprone:error_prone_annotations from 2.31.0 to 2.32.0 #492

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Bump com.google.errorprone:error_prone_annotations from 2.31.0 to 2.32.0 #492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbase/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@
<dep.assertj-core.version>3.26.3</dep.assertj-core.version>
<dep.byte-buddy.version>1.15.1</dep.byte-buddy.version>
<dep.checkstyle.version>10.18.1</dep.checkstyle.version>
<dep.errorprone.version>2.31.0</dep.errorprone.version>
<dep.errorprone.version>2.32.0</dep.errorprone.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version requires JDK 17 and airbase defaults to JDK 8 (<project.build.targetJdk>8</project.build.targetJdk>)
google/error-prone#3803 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thus airbase out of the box configuration doesn't work now.
We either revert this update, or change project.build.targetJdk default to be 17 or newer, dropping support for Java 8 and 11 in airbase.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Target is --release

<dep.guava.version>33.3.0-jre</dep.guava.version>
<dep.guice.version>7.0.0</dep.guice.version>
<dep.hibernate-validator.version>8.0.1.Final</dep.hibernate-validator.version>
Expand Down
Loading