Documentation: More details about using an external database #9611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alafanechere
added
the
area/documentation
alafanechere
requested review from
tuliren,
marcosmarxm and
harshithmullapudi
alafanechere
changed the title
marcosmarxm
approved these changes
Jan 19, 2022
tuliren
suggested changes
Jan 19, 2022
| * Through a dedicated custom Postgres instance \(the `airbyte/db` is in this case unused, and can therefore be removed or de-activated from the `docker-compose.yml` file\). | ||
| * Through a dedicated custom Postgres instance \(the `airbyte/db` is in this case unused, and can therefore be removed or de-activated from the `docker-compose.yml` file\). It's not a good practice to deploy mission-critical databases on Docker or Kubernetes. | ||
| Using a dedicated instance will provide more reliability to your Airbyte deployment. | ||
| Moreover, using a Cloud-managed Postgres instance (such as AWS RDS our GCP Cloud SQL), you will benefit from automatic backup and fine-grained sizing. You can pick a pretty small instance for a starter, as the Airbyte database will only host configurations and jobs metadata. |
There was a problem hiding this comment.
I am not sure we can say that our db instance is pretty small. Because we track job histories in the jobs database, that database can actually grow pretty large. We had OSS users before that had trouble running file-based migration because of the total database size. So it's probably better to remove the second half of the sentence?
Suggested change
| Moreover, using a Cloud-managed Postgres instance (such as AWS RDS our GCP Cloud SQL), you will benefit from automatic backup and fine-grained sizing. You can pick a pretty small instance for a starter, as the Airbyte database will only host configurations and jobs metadata. | |
| Moreover, using a Cloud-managed Postgres instance (such as AWS RDS our GCP Cloud SQL), you will benefit from automatic backup. |
There was a problem hiding this comment.
Ok, I'll rephrase this to suggest that they can start small but the job tables might grow according to their usage of Airbyte.
tuliren
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Some users are asking in which context they might want to use an external database for Airbyte.
How
I tried to update the doc to suggest it's more reliable to use an external database.