Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source notion: fix doc url #9084

Merged
merged 6 commits into from
Jan 11, 2022
Merged

Source notion: fix doc url #9084

merged 6 commits into from
Jan 11, 2022

Conversation

alafanechere
Copy link
Contributor

The documentationUrl in source-notion was not filled.

@github-actions github-actions bot added the area/connectors Connector related issues label Dec 23, 2021
@alafanechere
Copy link
Contributor Author

alafanechere commented Dec 23, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-notion

🕑 connectors/source-notion https://github.com/airbytehq/airbyte/actions/runs/1615857682
❌ connectors/source-notion https://github.com/airbytehq/airbyte/actions/runs/1615857682
🐛 https://gradle.com/s/jpaensuw2b5ay
Python short test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Please check...
======================== 1 failed, 15 passed in 30.05s =========================

@alafanechere alafanechere temporarily deployed to more-secrets December 23, 2021 14:06 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 23, 2021 14:08 Inactive
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Dec 23, 2021
@alafanechere alafanechere temporarily deployed to more-secrets December 23, 2021 14:53 Inactive
@marcosmarxm
Copy link
Member

Looks there is a problem with pages stream, can you correct the schema @alafanechere ?

@alafanechere
Copy link
Contributor Author

alafanechere commented Jan 11, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-notion

🕑 connectors/source-notion https://github.com/airbytehq/airbyte/actions/runs/1681436370
✅ connectors/source-notion https://github.com/airbytehq/airbyte/actions/runs/1681436370
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 base_python/__init__.py                       13      0   100%
	 base_python/catalog_helpers.py                10      6    40%
	 base_python/cdk/__init__.py                    0      0   100%
	 base_python/cdk/abstract_source.py            89     64    28%
	 base_python/cdk/streams/__init__.py            0      0   100%
	 base_python/cdk/streams/auth/__init__.py       0      0   100%
	 base_python/cdk/streams/auth/core.py           8      1    88%
	 base_python/cdk/streams/auth/jwt.py            5      5     0%
	 base_python/cdk/streams/auth/oauth.py         37     26    30%
	 base_python/cdk/streams/auth/token.py          9      4    56%
	 base_python/cdk/streams/core.py               63     32    49%
	 base_python/cdk/streams/exceptions.py         10      2    80%
	 base_python/cdk/streams/http.py               67     33    51%
	 base_python/cdk/streams/rate_limiting.py      30     14    53%
	 base_python/cdk/utils/__init__.py              0      0   100%
	 base_python/cdk/utils/casing.py                4      0   100%
	 base_python/cdk/utils/event_timing.py         47      3    94%
	 base_python/client.py                         56     33    41%
	 base_python/entrypoint.py                     70     56    20%
	 base_python/integration.py                    52     25    52%
	 base_python/logger.py                         33     15    55%
	 base_python/schema_helpers.py                 56     41    27%
	 base_python/source.py                         51     34    33%
	 main_dev.py                                    3      3     0%
	 --------------------------------------------------------------
	 TOTAL                                        713    397    44%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                        Stmts   Miss  Cover
	 -----------------------------------------------
	 source_notion/__init__.py       2      0   100%
	 source_notion/source.py        25      2    92%
	 source_notion/streams.py      115      5    96%
	 -----------------------------------------------
	 TOTAL                         142      7    95%

@alafanechere alafanechere temporarily deployed to more-secrets January 11, 2022 08:12 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 11, 2022 08:13 Inactive
@alafanechere
Copy link
Contributor Author

alafanechere commented Jan 11, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-notion

🕑 connectors/source-notion https://github.com/airbytehq/airbyte/actions/runs/1681552238
✅ connectors/source-notion https://github.com/airbytehq/airbyte/actions/runs/1681552238

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 11, 2022 08:45 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets January 11, 2022 08:59 Inactive
@alafanechere alafanechere merged commit a5d5eb7 into master Jan 11, 2022
@alafanechere alafanechere deleted the augustin/source-notion-fix-spec branch January 11, 2022 09:26
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm marcosmarxm approved these changes

@harshithmullapudi harshithmullapudi Awaiting requested review from harshithmullapudi

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alafanechere @marcosmarxm @jrhizor @octavia-squidington-iii