🐛 Destination Snowflake SQL compilation error #9006

VitaliiMaltsev · 2021-12-21T16:46:51Z

What

Syncing Google Analytics <> Snowflake and getting error:

35mdestination�[0m - 2021-12-16 19:33:49 ERROR LineGobbler(voidCall):82 - Exception in thread "main" net.snowflake.client.jdbc.SnowflakeSQLException: SQL compilation error:
�[35mdestination�[0m - 2021-12-16 19:33:49 ERROR LineGobbler(voidCall):82 - syntax error line 1 at position 39 unexpected 'Pages'.

How

Updated jdbc connection parameter schema to follow Snowflake naming convention

🚨 User Impact 🚨

There should be no visible impact on users

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

CLAassistant · 2021-12-21T16:46:58Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

vmaltsev seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

VitaliiMaltsev · 2021-12-21T16:50:19Z

/test connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1607788082
✅ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1607788082
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    13      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     124      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 13      0   100%
	 normalization/transform_catalog/stream_processor.py                 494    313    37%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         146     32    78%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1199    501    58%

edgao

can you add something to the documentation (or spec.json) saying that this transformation will happen automatically? other than that, this looks good to me

VitaliiMaltsev · 2021-12-21T17:48:44Z

can you add something to the documentation (or spec.json) saying that this transformation will happen automatically? other than that, this looks good to me

updated spec.json

VitaliiMaltsev · 2021-12-21T18:20:47Z

/publish connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1608115451
✅ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1608115451

sherifnada · 2021-12-21T23:58:14Z

...snowflake/src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeDatabase.java

@@ -32,7 +32,7 @@ public static Connection getConnection(final JsonNode config) throws SQLExceptio
    properties.put("warehouse", config.get("warehouse").asText());
    properties.put("database", config.get("database").asText());
    properties.put("role", config.get("role").asText());
-    properties.put("schema", config.get("schema").asText());
+    properties.put("schema", nameTransformer.getIdentifier(config.get("schema").asText()));


@edgao this is a good candidate for the testing ticket

edgao · 2021-12-22T00:16:56Z

@VitaliiMaltsev sorry, missed this in my review - can you add a unit test to prevent regression? It'll probably require mocking the static method DriverManager.getConnection (add testImplementation "org.mockito:mockito-inline:4.1.0" to the build.gradle + use Mockito.mockStatic)

VitaliiMaltsev · 2021-12-22T19:48:39Z

@VitaliiMaltsev sorry, missed this in my review - can you add a unit test to prevent regression? It'll probably require mocking the static method DriverManager.getConnection (add testImplementation "org.mockito:mockito-inline:4.1.0" to the build.gradle + use Mockito.mockStatic)

@edgao i think that connection mocking is not enough so i created integration test for more realistic test scenario https://github.com/airbytehq/airbyte/pull/9065/files . Please review

vmaltsev added 10 commits December 15, 2021 10:45

fix for jdk 17

93d53ac

Merge branch 'master' of github.com:airbytehq/airbyte

ede8d38

Merge branch 'master' of github.com:airbytehq/airbyte

27be3fe

Merge branch 'master' of github.com:airbytehq/airbyte

ca75033

Merge branch 'master' of github.com:airbytehq/airbyte

72ab46f

Merge branch 'master' of github.com:airbytehq/airbyte

aec3384

Merge branch 'master' of github.com:airbytehq/airbyte

7efd5aa

Merge branch 'master' of github.com:airbytehq/airbyte

6a773f9

Merge branch 'master' of github.com:airbytehq/airbyte

fa18537

updated SnowflakeDatabase jdbc connection params

8b92a8d

VitaliiMaltsev requested a review from sherifnada December 21, 2021 16:47

github-actions bot added the area/connectors Connector related issues label Dec 21, 2021

VitaliiMaltsev requested a review from edgao December 21, 2021 16:51

jrhizor temporarily deployed to more-secrets December 21, 2021 16:52 Inactive

edgao reviewed Dec 21, 2021

View reviewed changes

updated spec.json

dbb2d95

VitaliiMaltsev temporarily deployed to more-secrets December 21, 2021 17:48 Inactive

VitaliiMaltsev requested a review from edgao December 21, 2021 17:48

edgao approved these changes Dec 21, 2021

View reviewed changes

updated spec.json

6378294

github-actions bot added the area/documentation Improvements or additions to documentation label Dec 21, 2021

VitaliiMaltsev temporarily deployed to more-secrets December 21, 2021 18:20 Inactive

jrhizor temporarily deployed to more-secrets December 21, 2021 18:22 Inactive

VitaliiMaltsev merged commit 287cdb5 into master Dec 21, 2021

VitaliiMaltsev deleted the vmaltsev/destination-snowflake-update-schema-naming branch December 21, 2021 19:32

sherifnada reviewed Dec 21, 2021

View reviewed changes

jrhizor mentioned this pull request Dec 22, 2021

Bump Airbyte version from 0.34.4-alpha to 0.35.0-alpha #9023

Merged

karinakuz added connectors/destinations-warehouse connectors/destination/snowflake labels Jan 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Destination Snowflake SQL compilation error #9006

🐛 Destination Snowflake SQL compilation error #9006

VitaliiMaltsev commented Dec 21, 2021 •

edited

Loading

CLAassistant commented Dec 21, 2021

VitaliiMaltsev commented Dec 21, 2021 •

edited by github-actions bot

Loading

edgao left a comment •

edited

Loading

VitaliiMaltsev commented Dec 21, 2021

VitaliiMaltsev commented Dec 21, 2021 •

edited by github-actions bot

Loading

sherifnada Dec 21, 2021

edgao commented Dec 22, 2021

VitaliiMaltsev commented Dec 22, 2021

🐛 Destination Snowflake SQL compilation error #9006

🐛 Destination Snowflake SQL compilation error #9006

Conversation

VitaliiMaltsev commented Dec 21, 2021 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

CLAassistant commented Dec 21, 2021

VitaliiMaltsev commented Dec 21, 2021 • edited by github-actions bot Loading

edgao left a comment • edited Loading

Choose a reason for hiding this comment

VitaliiMaltsev commented Dec 21, 2021

VitaliiMaltsev commented Dec 21, 2021 • edited by github-actions bot Loading

sherifnada Dec 21, 2021

Choose a reason for hiding this comment

edgao commented Dec 22, 2021

VitaliiMaltsev commented Dec 22, 2021

VitaliiMaltsev commented Dec 21, 2021 •

edited

Loading

VitaliiMaltsev commented Dec 21, 2021 •

edited by github-actions bot

Loading

edgao left a comment •

edited

Loading

VitaliiMaltsev commented Dec 21, 2021 •

edited by github-actions bot

Loading