Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination MariaDbColumnstore: update Docker image for acceptance tests #8840

Merged

Conversation

VitaliiMaltsev
Copy link
Contributor

@VitaliiMaltsev VitaliiMaltsev commented Dec 16, 2021

What

Destination MariaDB use latest tag for Docker image

How

Updated Docker image for acceptance tests

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

None user impact

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


vmaltsev seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Dec 16, 2021
@VitaliiMaltsev VitaliiMaltsev temporarily deployed to more-secrets December 16, 2021 11:55 Inactive
@VitaliiMaltsev VitaliiMaltsev changed the title Destination MariaDbColumnstote: update Docker image for acceptance tests Destination MariaDbColumnstore: update Docker image for acceptance tests Dec 16, 2021
@VitaliiMaltsev VitaliiMaltsev temporarily deployed to more-secrets December 16, 2021 11:59 Inactive
@github-actions github-actions bot removed the area/documentation Improvements or additions to documentation label Dec 16, 2021
@VitaliiMaltsev
Copy link
Contributor Author

VitaliiMaltsev commented Dec 16, 2021

/test connector=connectors/destination-mariadb-columnstore

🕑 connectors/destination-mariadb-columnstore https://github.com/airbytehq/airbyte/actions/runs/1587332462
✅ connectors/destination-mariadb-columnstore https://github.com/airbytehq/airbyte/actions/runs/1587332462
No Python unittests run

@VitaliiMaltsev VitaliiMaltsev temporarily deployed to more-secrets December 16, 2021 12:01 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 16, 2021 12:02 Inactive
@VitaliiMaltsev VitaliiMaltsev marked this pull request as ready for review December 17, 2021 10:41
Copy link
Contributor

@alexandr-shegeda alexandr-shegeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. we can proceed with publish and merge without airbyte review

@VitaliiMaltsev VitaliiMaltsev merged commit 415a208 into master Dec 17, 2021
@VitaliiMaltsev VitaliiMaltsev deleted the vmaltsev/8672-destination-mariadb-update-docker-image branch December 17, 2021 11:10
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
…sts (airbytehq#8840)

* fix for jdk 17

* Destination MariaDbColumnstore updated Docker image

* update Docker image for ssh tests

Co-authored-by: vmaltsev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants