🎉 Setting CPU and Memory limits for performance tests via github #8807

andriikorotkov · 2021-12-15T09:23:57Z

What

Setting CPU and Memory limits for performance tests via github

How

Now you can set the CPU and Memory limits using the github command. Added two optional parameters cpulimit and memorylimit, which allow you to control the limits for performance tests. cpulimit and memorylimit must be specified in the following form - cpulimit=cpulimit/4 and memorylimit=memorylimit/2GB.

🚨 User Impact 🚨

No impact

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

…change-sh-for-cpu-and-memory

…change-sh-for-cpu-and-memory � Conflicts: � .github/workflows/test-performance-command.yml

…change-sh-for-cpu-and-memory

andriikorotkov · 2021-12-16T10:59:37Z

/test-performance connector=connectors/source-mssql cpulimit=cpulimit/4 memorylimit=memorylimit/2GB

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/1587113709
✅ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/1587113709

…change-sh-for-cpu-and-memory

andriikorotkov · 2021-12-16T14:58:39Z

/test-performance connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/1588045139
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/1588045139

andriikorotkov · 2021-12-16T16:44:06Z

/test-performance connector=connectors/source-postgres cpulimit=cpulimit/4 memorylimit=memorylimit/2GB

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/1588485403
❌ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/1588485403
🐛 https://gradle.com/s/4gfj2psz7hs4q

andriikorotkov · 2021-12-16T17:34:42Z

/test-performance connector=connectors/source-postgres cpulimit=cpulimit/4 memorylimit=memorylimit/3GB

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/1588682784
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/1588682784

andriikorotkov · 2021-12-16T18:35:20Z

/test-performance connector=connectors/source-postgres cpulimit=cpulimit/4

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/1588914433
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/1588914433

…change-sh-for-cpu-and-memory

…bytehq#8807) * updated ci performance test sh script * updated ci performance test sh script * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * run tests * update ci creds * update performance test yaml file * update performance test yaml file * update performance test yaml file * update performance test yaml file * update performance test sh file * update performance test sh file * update performance test sh file * update performance test sh file * update java to 17 version in yaml file for performance tests * update java to 17 version in yaml file for performance tests * update java to 17 version in yaml file for performance tests * update java to 17 version in yaml file for performance tests * update java to 17 version in yaml file for performance tests * clean test logs * remove test logs * remove test logs * remove test logs * return performance test logs * add readme by performance tests

andriikorotkov added 30 commits December 10, 2021 17:04

updated ci performance test sh script

c55f8f4

updated ci performance test sh script

0936d6e

Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…

4576cdc

…change-sh-for-cpu-and-memory

set all params to one arg

bf8b04d

set all params to one arg

44ce7a7

Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…

9fe0591

…change-sh-for-cpu-and-memory

set all params to one arg

993c05f

Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…

9aec23a

…change-sh-for-cpu-and-memory � Conflicts: � .github/workflows/test-performance-command.yml

set all params to one arg

456585c

Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…

c4998ce

…change-sh-for-cpu-and-memory

set all params to one arg

b360e79

set all params to one arg

a2221ab

set all params to one arg

48f05f3

Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…

e6b3f99

…change-sh-for-cpu-and-memory

set all params to one arg

6cf24aa

Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…

c253bce

…change-sh-for-cpu-and-memory

set all params to one arg

71aecf9

Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…

0940ab3

…change-sh-for-cpu-and-memory

set all params to one arg

b310fb6

Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…

c05e612

…change-sh-for-cpu-and-memory

set all params to one arg

a389242

Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…

13217a6

…change-sh-for-cpu-and-memory

set all params to one arg

f1bf79d

set all params to one arg

4f01556

set all params to one arg

38e1bb2

set all params to one arg

ee3d6c6

set all params to one arg

45801b3

set all params to one arg

3299e8e

set all params to one arg

9ed85da

set all params to one arg

82dc985

jrhizor temporarily deployed to more-secrets December 16, 2021 11:01 Inactive

Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…

e843620

…change-sh-for-cpu-and-memory

andriikorotkov temporarily deployed to more-secrets December 16, 2021 14:14 Inactive

jrhizor temporarily deployed to more-secrets December 16, 2021 15:00 Inactive

remove test logs

d304593

github-actions bot added the area/connectors Connector related issues label Dec 16, 2021

andriikorotkov temporarily deployed to more-secrets December 16, 2021 16:44 Inactive

jrhizor temporarily deployed to more-secrets December 16, 2021 16:46 Inactive

jrhizor temporarily deployed to more-secrets December 16, 2021 17:36 Inactive

jrhizor temporarily deployed to more-secrets December 16, 2021 18:37 Inactive

return performance test logs

d0d2612

github-actions bot removed the area/connectors Connector related issues label Dec 17, 2021

andriikorotkov temporarily deployed to more-secrets December 17, 2021 08:19 Inactive

add readme by performance tests

5102612

github-actions bot added the area/connectors Connector related issues label Dec 17, 2021

Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…

87f72c2

…change-sh-for-cpu-and-memory

andriikorotkov temporarily deployed to more-secrets December 17, 2021 09:17 Inactive

andriikorotkov marked this pull request as ready for review December 17, 2021 10:47

andriikorotkov merged commit 0c99c5d into master Dec 17, 2021

andriikorotkov deleted the akorotkov/change-sh-for-cpu-and-memory branch December 17, 2021 10:47

This was referenced Dec 19, 2021

Bump Airbyte version from 0.34.1-alpha to 0.34.2-alpha #8900

Merged

Bump Airbyte version from 0.34.1-alpha to 0.34.2-alpha #8901

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Setting CPU and Memory limits for performance tests via github #8807

🎉 Setting CPU and Memory limits for performance tests via github #8807

andriikorotkov commented Dec 15, 2021 •

edited

Loading

andriikorotkov commented Dec 16, 2021 •

edited by github-actions bot

Loading

andriikorotkov commented Dec 16, 2021 •

edited by github-actions bot

Loading

andriikorotkov commented Dec 16, 2021 •

edited by github-actions bot

Loading

andriikorotkov commented Dec 16, 2021 •

edited by github-actions bot

Loading

andriikorotkov commented Dec 16, 2021 •

edited by github-actions bot

Loading

🎉 Setting CPU and Memory limits for performance tests via github #8807

🎉 Setting CPU and Memory limits for performance tests via github #8807

Conversation

andriikorotkov commented Dec 15, 2021 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

andriikorotkov commented Dec 16, 2021 • edited by github-actions bot Loading

andriikorotkov commented Dec 16, 2021 • edited by github-actions bot Loading

andriikorotkov commented Dec 16, 2021 • edited by github-actions bot Loading

andriikorotkov commented Dec 16, 2021 • edited by github-actions bot Loading

andriikorotkov commented Dec 16, 2021 • edited by github-actions bot Loading

andriikorotkov commented Dec 15, 2021 •

edited

Loading

andriikorotkov commented Dec 16, 2021 •

edited by github-actions bot

Loading

andriikorotkov commented Dec 16, 2021 •

edited by github-actions bot

Loading

andriikorotkov commented Dec 16, 2021 •

edited by github-actions bot

Loading

andriikorotkov commented Dec 16, 2021 •

edited by github-actions bot

Loading

andriikorotkov commented Dec 16, 2021 •

edited by github-actions bot

Loading