🎉 Source Facebook Marketing: fix schema for 'breakdowns' fields #8742

grubberr · 2021-12-13T13:25:39Z

Signed-off-by: Sergey Chvalyuk [email protected]

What

Bugfix schema generation for AdsInsightsstream and it's child streams.

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Signed-off-by: Sergey Chvalyuk <[email protected]>

grubberr · 2021-12-13T21:48:56Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1575053601
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1575053601
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        76      8    89%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              235     95    60%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     24    56%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  946    442    53%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                     Stmts   Miss  Cover
	 ------------------------------------------------------------
	 source_facebook_marketing/__init__.py        2      0   100%
	 source_facebook_marketing/api.py            75     17    77%
	 source_facebook_marketing/async_job.py      92     58    37%
	 source_facebook_marketing/common.py         37     11    70%
	 source_facebook_marketing/source.py        113     66    42%
	 source_facebook_marketing/streams.py       239     81    66%
	 ------------------------------------------------------------
	 TOTAL                                      558    233    58%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                     Stmts   Miss  Cover
	 ------------------------------------------------------------
	 source_facebook_marketing/__init__.py        2      0   100%
	 source_facebook_marketing/api.py            75     18    76%
	 source_facebook_marketing/async_job.py      92      1    99%
	 source_facebook_marketing/common.py         37      1    97%
	 source_facebook_marketing/source.py        113     73    35%
	 source_facebook_marketing/streams.py       239     81    66%
	 ------------------------------------------------------------
	 TOTAL                                      558    174    69%

keu · 2021-12-13T23:35:41Z

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

@@ -169,7 +169,7 @@
 - name: Facebook Marketing
  sourceDefinitionId: e7778cfc-e97c-4458-9ecb-b4f2bba8946c
  dockerRepository: airbyte/source-facebook-marketing
-  dockerImageTag: 0.2.26
+  dockerImageTag: 0.2.27


this needs to be updated after publish only

keu

just small comment, LGTM otherwise

Signed-off-by: Sergey Chvalyuk <[email protected]>

grubberr · 2021-12-16T12:18:36Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1587406756
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1587406756
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        76      8    89%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              235     95    60%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     24    56%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py       101     65    36%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  965    458    53%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                     Stmts   Miss  Cover
	 ------------------------------------------------------------
	 source_facebook_marketing/__init__.py        2      0   100%
	 source_facebook_marketing/api.py            75     17    77%
	 source_facebook_marketing/async_job.py      92     58    37%
	 source_facebook_marketing/common.py         37     11    70%
	 source_facebook_marketing/source.py        113     66    42%
	 source_facebook_marketing/streams.py       236     78    67%
	 ------------------------------------------------------------
	 TOTAL                                      555    230    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                     Stmts   Miss  Cover
	 ------------------------------------------------------------
	 source_facebook_marketing/__init__.py        2      0   100%
	 source_facebook_marketing/api.py            75     18    76%
	 source_facebook_marketing/async_job.py      92      1    99%
	 source_facebook_marketing/common.py         37      1    97%
	 source_facebook_marketing/source.py        113     73    35%
	 source_facebook_marketing/streams.py       236     78    67%
	 ------------------------------------------------------------
	 TOTAL                                      555    171    69%

docs/integrations/sources/facebook-marketing.md

Signed-off-by: Serhii Chvaliuk <[email protected]>

sherifnada · 2021-12-17T00:15:47Z

@grubberr airbyte review not needed as it doesn't affect ux, internal is sufficient

Signed-off-by: Sergey Chvalyuk <[email protected]>

grubberr · 2021-12-17T12:23:22Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1592186670
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1592186670
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        76      8    89%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     24    56%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py       101     65    36%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  972    459    53%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                     Stmts   Miss  Cover
	 ------------------------------------------------------------
	 source_facebook_marketing/__init__.py        2      0   100%
	 source_facebook_marketing/api.py            75     17    77%
	 source_facebook_marketing/async_job.py      92     58    37%
	 source_facebook_marketing/common.py         37     11    70%
	 source_facebook_marketing/source.py        113     66    42%
	 source_facebook_marketing/streams.py       236     78    67%
	 ------------------------------------------------------------
	 TOTAL                                      555    230    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                     Stmts   Miss  Cover
	 ------------------------------------------------------------
	 source_facebook_marketing/__init__.py        2      0   100%
	 source_facebook_marketing/api.py            75     18    76%
	 source_facebook_marketing/async_job.py      92      1    99%
	 source_facebook_marketing/common.py         37      1    97%
	 source_facebook_marketing/source.py        113     73    35%
	 source_facebook_marketing/streams.py       236     78    67%
	 ------------------------------------------------------------
	 TOTAL                                      555    171    69%

grubberr · 2021-12-17T14:34:35Z

/publish connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1592687125
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1592687125

Signed-off-by: Sergey Chvalyuk <[email protected]>

…ytehq#8742) * fix schema for 'breakdowns' and 'action_breakdowns fields Signed-off-by: Sergey Chvalyuk <[email protected]>

- bump 0.2.26 -> 0.2.27

e8242b2

Signed-off-by: Sergey Chvalyuk <[email protected]>

grubberr self-assigned this Dec 13, 2021

github-actions bot added the area/connectors Connector related issues label Dec 13, 2021

grubberr linked an issue Dec 13, 2021 that may be closed by this pull request

🐛 Source Facebook Marketing: discover is broke when using valid breakdown value in a custom insight #8437

Closed

grubberr added 2 commits December 13, 2021 22:12

Merge branch 'master' into grubberr/8437-source-facebook-marketing

dddb797

fix schema for 'breakdowns' and 'action_breakdowns fields

7e47deb

Signed-off-by: Sergey Chvalyuk <[email protected]>

grubberr temporarily deployed to more-secrets December 13, 2021 21:42 Inactive

facebook-marketing.md updated

fa5b035

Signed-off-by: Sergey Chvalyuk <[email protected]>

github-actions bot added the area/documentation Improvements or additions to documentation label Dec 13, 2021

grubberr temporarily deployed to more-secrets December 13, 2021 21:49 Inactive

jrhizor temporarily deployed to more-secrets December 13, 2021 21:51 Inactive

grubberr requested a review from keu December 13, 2021 22:02

keu reviewed Dec 13, 2021

View reviewed changes

keu approved these changes Dec 13, 2021

View reviewed changes

grubberr added 2 commits December 16, 2021 14:04

Merge branch 'master' into grubberr/8437-source-facebook-marketing

09102bb

don't show action_breakdowns in discovery schemas

5d39dd0

Signed-off-by: Sergey Chvalyuk <[email protected]>

grubberr temporarily deployed to more-secrets December 16, 2021 12:19 Inactive

jrhizor temporarily deployed to more-secrets December 16, 2021 12:20 Inactive

grubberr changed the title ~~🎉 Source Facebook Marketing: fix schema for 'breakdowns' and 'action_breakdowns fields'~~ 🎉 Source Facebook Marketing: fix schema for 'breakdowns' fields Dec 16, 2021

grubberr requested review from antixar and bazarnov December 16, 2021 12:24

bazarnov reviewed Dec 16, 2021

View reviewed changes

docs/integrations/sources/facebook-marketing.md Outdated Show resolved Hide resolved

bazarnov approved these changes Dec 16, 2021

View reviewed changes

fix "fix message" :)

2392115

Signed-off-by: Serhii Chvaliuk <[email protected]>

grubberr temporarily deployed to more-secrets December 16, 2021 12:36 Inactive

grubberr requested a review from sherifnada December 16, 2021 16:03

antixar approved these changes Dec 17, 2021

View reviewed changes

Merge branch 'master' into grubberr/8437-source-facebook-marketing

e53cba1

Signed-off-by: Sergey Chvalyuk <[email protected]>

grubberr temporarily deployed to more-secrets December 17, 2021 12:21 Inactive

jrhizor temporarily deployed to more-secrets December 17, 2021 12:25 Inactive

jrhizor temporarily deployed to more-secrets December 17, 2021 14:36 Inactive

source_specs.yaml updated

2f1161c

Signed-off-by: Sergey Chvalyuk <[email protected]>

grubberr merged commit 0d7101e into master Dec 17, 2021

grubberr deleted the grubberr/8437-source-facebook-marketing branch December 17, 2021 14:52

grubberr temporarily deployed to more-secrets December 17, 2021 14:52 Inactive

This was referenced Dec 19, 2021

Bump Airbyte version from 0.34.1-alpha to 0.34.2-alpha #8900

Merged

Bump Airbyte version from 0.34.1-alpha to 0.34.2-alpha #8901

Merged

yurii-bidiuk added a commit that referenced this pull request Dec 20, 2021

bump version for affected sources from #8742

d645509

karinakuz added connectors/sources-api connectors/source/facebook-marketing labels Jan 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Source Facebook Marketing: fix schema for 'breakdowns' fields #8742

🎉 Source Facebook Marketing: fix schema for 'breakdowns' fields #8742

grubberr commented Dec 13, 2021 •

edited

Loading

grubberr commented Dec 13, 2021 •

edited by github-actions bot

Loading

keu Dec 13, 2021

keu left a comment

grubberr commented Dec 16, 2021 •

edited by github-actions bot

Loading

sherifnada commented Dec 17, 2021

grubberr commented Dec 17, 2021 •

edited by github-actions bot

Loading

grubberr commented Dec 17, 2021 •

edited by github-actions bot

Loading

🎉 Source Facebook Marketing: fix schema for 'breakdowns' fields #8742

🎉 Source Facebook Marketing: fix schema for 'breakdowns' fields #8742

Conversation

grubberr commented Dec 13, 2021 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

grubberr commented Dec 13, 2021 • edited by github-actions bot Loading

keu Dec 13, 2021

Choose a reason for hiding this comment

keu left a comment

Choose a reason for hiding this comment

grubberr commented Dec 16, 2021 • edited by github-actions bot Loading

sherifnada commented Dec 17, 2021

grubberr commented Dec 17, 2021 • edited by github-actions bot Loading

grubberr commented Dec 17, 2021 • edited by github-actions bot Loading

grubberr commented Dec 13, 2021 •

edited

Loading

grubberr commented Dec 13, 2021 •

edited by github-actions bot

Loading

grubberr commented Dec 16, 2021 •

edited by github-actions bot

Loading

grubberr commented Dec 17, 2021 •

edited by github-actions bot

Loading

grubberr commented Dec 17, 2021 •

edited by github-actions bot

Loading