Destination Snowflake: Return Standard Loading #8528

VitaliiMaltsev · 2021-12-06T11:06:06Z

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

…al-staging

…al-staging # Conflicts: # airbyte-integrations/connectors/destination-snowflake/src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeInternalStagingConsumerFactory.java # airbyte-integrations/connectors/destination-snowflake/src/main/resources/spec.json

CLAassistant · 2021-12-06T11:06:12Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

vmaltsev seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

sherifnada · 2021-12-06T16:55:55Z

airbyte-integrations/connectors/destination-snowflake/src/main/resources/spec.json

@@ -87,6 +87,19 @@
              }
            }
          },
+          {
+            "title": "Standard Inserts",


can you:

set hidden: true to hide this option from the UI (no one should be using it anymore)

in the connector, use internal staging when this option is set

@sherifnada, when hidden is set to true, what will the UI show for a connection already set to standard loading? Will it cause a UI exception?

actually nvm, let's just do this option for now and handle what I suggested in a follow up PR just to unblock current users

I think hidden won't work for enum values actually so I was wrong. migration will be a little more complex

Yes, hidden: true won't work for oneOf. Just tested it on UI

VitaliiMaltsev · 2021-12-06T17:45:24Z

/test connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1545874115
✅ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1545874115
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    12      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     120      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 11      0   100%
	 normalization/transform_catalog/stream_processor.py                 468    287    39%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         140     29    79%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1160    472    59%

tuliren · 2021-12-06T18:09:20Z

@VitaliiMaltsev, FYI, sorry that we actually should remove hidden. See the discussion in the comments above. Could you update it before publishing? Also don't forget to bump the version, and update the CHANGELOG.

@tuliren removed hidden: true option and bumped to 0.3.19 version. Can i publish it now?

tuliren · 2021-12-06T18:20:52Z

@VitaliiMaltsev, yes, feel free to publish the new version. Thanks~~

VitaliiMaltsev · 2021-12-06T19:24:27Z

/publish connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1546246211
✅ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1546246211

* Snowflake Destination: implemented internal staging * fix checkstyle * improved perfomance of sync * added changelog * test refactoring * removed file chunking * add docs * added javadoc, updated spec * refactoring * bump version * return Standard Inserts into spec * hide Standard inserts option, set Internal staging as default option * remove hidden: true from spec * bump version 0.3.19 Co-authored-by: vmaltsev <[email protected]>

vmaltsev added 15 commits November 25, 2021 17:19

Snowflake Destination: implemented internal staging

6b23ff7

fix checkstyle

273ce69

Merge branch 'master' into vmaltsev/4370-destination-snowflake-intern…

b64c903

…al-staging

improved perfomance of sync

da62f7a

added changelog

0572b94

test refactoring

4480e13

removed file chunking

0d5249a

add docs

76ef1ac

added javadoc, updated spec

736f061

refactoring

77db1b4

Merge branch 'master' into vmaltsev/4370-destination-snowflake-intern…

84c61f5

…al-staging

bump version

0a37372

Merge branch 'master' into vmaltsev/4370-destination-snowflake-intern…

03251a9

…al-staging

return Standard Inserts into spec

96dfefd

VitaliiMaltsev requested a review from tuliren December 6, 2021 11:06

github-actions bot added the area/connectors Connector related issues label Dec 6, 2021

VitaliiMaltsev temporarily deployed to more-secrets December 6, 2021 11:06 Inactive

VitaliiMaltsev linked an issue Dec 6, 2021 that may be closed by this pull request

Snowflake destination: Support internal staging #4370

Closed

VitaliiMaltsev mentioned this pull request Dec 6, 2021

Snowflake destination: Support internal staging #4370

Closed

sherifnada reviewed Dec 6, 2021

View reviewed changes

hide Standard inserts option, set Internal staging as default option

b59ec20

VitaliiMaltsev temporarily deployed to more-secrets December 6, 2021 17:45 Inactive

jrhizor temporarily deployed to more-secrets December 6, 2021 17:47 Inactive

tuliren approved these changes Dec 6, 2021

View reviewed changes

remove hidden: true from spec

5fac3cb

VitaliiMaltsev temporarily deployed to more-secrets December 6, 2021 18:14 Inactive

bump version 0.3.19

ea8483f

github-actions bot added the area/documentation Improvements or additions to documentation label Dec 6, 2021

VitaliiMaltsev temporarily deployed to more-secrets December 6, 2021 18:18 Inactive

jrhizor temporarily deployed to more-secrets December 6, 2021 19:26 Inactive

VitaliiMaltsev merged commit f9d8e39 into master Dec 6, 2021

VitaliiMaltsev deleted the vmaltsev/4370-destination-snowflake-internal-staging branch December 6, 2021 20:39

jrhizor mentioned this pull request Dec 6, 2021

Bump Airbyte version from 0.33.4-alpha to 0.33.5-alpha #8565

Merged

karinakuz added connectors/destinations-warehouse connectors/destination/snowflake labels Jan 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Destination Snowflake: Return Standard Loading #8528

Destination Snowflake: Return Standard Loading #8528

VitaliiMaltsev commented Dec 6, 2021

CLAassistant commented Dec 6, 2021

sherifnada Dec 6, 2021

tuliren Dec 6, 2021

sherifnada Dec 6, 2021

sherifnada Dec 6, 2021

VitaliiMaltsev Dec 6, 2021

VitaliiMaltsev commented Dec 6, 2021 •

edited by github-actions bot

Loading

tuliren commented Dec 6, 2021 •

edited

Loading

tuliren commented Dec 6, 2021

VitaliiMaltsev commented Dec 6, 2021 •

edited by github-actions bot

Loading

Destination Snowflake: Return Standard Loading #8528

Destination Snowflake: Return Standard Loading #8528

Conversation

VitaliiMaltsev commented Dec 6, 2021

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

CLAassistant commented Dec 6, 2021

sherifnada Dec 6, 2021

Choose a reason for hiding this comment

tuliren Dec 6, 2021

Choose a reason for hiding this comment

sherifnada Dec 6, 2021

Choose a reason for hiding this comment

sherifnada Dec 6, 2021

Choose a reason for hiding this comment

VitaliiMaltsev Dec 6, 2021

Choose a reason for hiding this comment

VitaliiMaltsev commented Dec 6, 2021 • edited by github-actions bot Loading

tuliren commented Dec 6, 2021 • edited Loading

tuliren commented Dec 6, 2021

VitaliiMaltsev commented Dec 6, 2021 • edited by github-actions bot Loading

VitaliiMaltsev commented Dec 6, 2021 •

edited by github-actions bot

Loading

tuliren commented Dec 6, 2021 •

edited

Loading

VitaliiMaltsev commented Dec 6, 2021 •

edited by github-actions bot

Loading