-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change COPY to ADD in dockerfiles to reduce java images #8516
Change COPY to ADD in dockerfiles to reduce java images #8516
Conversation
@haoranyu can you post some images you have built using this new strategy and compare with the older build? |
@alexandr-shegeda can someone from the team review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thanks for the contribution @haoranyu
Because isn't a new feature or something critical for connectors I won't release a new version at the moment. |
We noticed that after changing COPY with ADD in the Dockerfile all integration tests start failing, so we will revert these changes until we find a root cause and fix the tests. Here is the ticket for tracking progress #8996 |
…#8516) Co-authored-by: Oleksandr Sheheda <[email protected]>
What
As described in #7551, we can reduce java image sizes.
How
It can be achieved by using
ADD
instead ofCOPY
in dockerfiles.Recommended reading order
airbyte-integrations/bases/*
airbyte-integrations/connector-templates/*
airbyte-integrations/connectors/*
🚨 User Impact 🚨
No.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes