🎉 Source TikTok Marketing: support oauth flow #7636

annalvova05 · 2021-11-04T14:42:46Z

What

Add TikTok Marketing OAuth support.

How

Change spec.py and source.py. Add java part.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here

This change is

…oauth # Conflicts: # .github/workflows/publish-command.yml # .github/workflows/test-command.yml # airbyte-integrations/connectors/source-tiktok-marketing/source_tiktok_marketing/source.py # airbyte-integrations/connectors/source-tiktok-marketing/source_tiktok_marketing/spec.py # docs/integrations/sources/tiktok-marketing.md # tools/bin/ci_credentials.sh

…oauth

…oauth # Conflicts: # airbyte-oauth/src/main/java/io/airbyte/oauth/OAuthImplementationFactory.java

annalvova05 · 2022-01-19T14:58:46Z

/test connector=connectors/source-tiktok-marketing

🕑 connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/1718643150
✅ connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/1718643150
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                  Stmts   Miss  Cover
	 ---------------------------------------------------------
	 source_tiktok_marketing/__init__.py       2      0   100%
	 source_tiktok_marketing/source.py        40     12    70%
	 source_tiktok_marketing/spec.py          65     19    71%
	 source_tiktok_marketing/streams.py      294     88    70%
	 ---------------------------------------------------------
	 TOTAL                                   401    119    70%

antixar

Some minor comments

airbyte-integrations/connectors/source-tiktok-marketing/source_tiktok_marketing/source.py

antixar · 2022-01-19T18:17:22Z

airbyte-oauth/src/main/java/io/airbyte/oauth/flows/TikTokMarketingOAuthFlow.java

+    final URIBuilder builder = new URIBuilder()
+        .setScheme("https")
+        .setHost("ads.tiktok.com")
+        .setPath("marketing_api/auth")


why does this logic use "ads.tiktok.com" here but for loading of access tokens another one (business-api.tiktok.com)?
I remember that ads.tiktok.com is the old API domain. Please check

As I can see in the documentation, TikTok changed its hostname only for API (ads.tiktok.com/open_api -> business-api.tiktok.com/open_api). Also, there is an Advertiser authorization URL in TikTok Apps Basic information, it starts from ads.tiktok.com.

…oauth # Conflicts: # airbyte-oauth/src/main/java/io/airbyte/oauth/OAuthImplementationFactory.java

antixar

LGTM
Please publish your changes

annalvova05 · 2022-01-21T20:23:15Z

/test connector=connectors/source-tiktok-marketing

🕑 connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/1730632705
✅ connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/1730632705
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                  Stmts   Miss  Cover
	 ---------------------------------------------------------
	 source_tiktok_marketing/__init__.py       2      0   100%
	 source_tiktok_marketing/source.py        45     16    64%
	 source_tiktok_marketing/spec.py          65     19    71%
	 source_tiktok_marketing/streams.py      294     88    70%
	 ---------------------------------------------------------
	 TOTAL                                   406    123    70%

annalvova05 · 2022-01-21T20:37:17Z

/publish connector=connectors/source-tiktok-marketing

🕑 connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/1730687870
✅ connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/1730687870

add oauth

a28c208

annalvova05 self-assigned this Nov 4, 2021

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Nov 4, 2021

bump version

db0a242

annalvova05 linked an issue Nov 4, 2021 that may be closed by this pull request

Source TikTok Marketing: support oauth #7098

Closed

annalvova05 temporarily deployed to more-secrets November 4, 2021 14:45 Inactive

annalvova05 marked this pull request as draft December 30, 2021 09:29

annalvova05 temporarily deployed to more-secrets December 30, 2021 09:30 Inactive

upd schema

21ef9f7

annalvova05 temporarily deployed to more-secrets January 4, 2022 18:28 Inactive

upd oauth in spec

4437060

annalvova05 temporarily deployed to more-secrets January 4, 2022 20:55 Inactive

annalvova05 added 2 commits January 4, 2022 23:18

Merge remote-tracking branch 'origin/master' into alvova/7098-tiktok-…

afe6446

…oauth

add java part

789e491

annalvova05 temporarily deployed to more-secrets January 10, 2022 09:10 Inactive

annalvova05 added 2 commits January 18, 2022 12:35

change oauth params

de883f4

change spec

9a4f395

annalvova05 temporarily deployed to more-secrets January 18, 2022 10:37 Inactive

change spec

51861d8

annalvova05 temporarily deployed to more-secrets January 18, 2022 11:36 Inactive

upd java

637f1fd

annalvova05 temporarily deployed to more-secrets January 18, 2022 12:13 Inactive

upd spec

0af1f24

annalvova05 temporarily deployed to more-secrets January 18, 2022 12:18 Inactive

upd extractOAuthOutput

f809571

annalvova05 temporarily deployed to more-secrets January 18, 2022 12:34 Inactive

annalvova05 added 2 commits January 18, 2022 18:33

upd spec.py

7ff08ac

Merge remote-tracking branch 'origin/master' into alvova/7098-tiktok-…

5d2a8cc

…oauth # Conflicts: # airbyte-oauth/src/main/java/io/airbyte/oauth/OAuthImplementationFactory.java

remove spec.json

f694c10

annalvova05 temporarily deployed to more-secrets January 19, 2022 14:55 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 19, 2022 15:01 Inactive

annalvova05 marked this pull request as ready for review January 19, 2022 15:14

annalvova05 requested review from antixar and bazarnov January 19, 2022 15:14

annalvova05 changed the title ~~🎉 Source TikTok Ads: support oauth flow~~ 🎉 Source TikTok Marketing: support oauth flow Jan 19, 2022

bazarnov approved these changes Jan 19, 2022

View reviewed changes

antixar reviewed Jan 19, 2022

View reviewed changes

annalvova05 added 2 commits January 20, 2022 12:39

upd _prepare_stream_args after review

b150d04

Merge remote-tracking branch 'origin/master' into alvova/7098-tiktok-…

1223795

…oauth # Conflicts: # airbyte-oauth/src/main/java/io/airbyte/oauth/OAuthImplementationFactory.java

annalvova05 requested a review from antixar January 20, 2022 10:41

annalvova05 temporarily deployed to more-secrets January 20, 2022 10:42 Inactive

format

8ae8bed

annalvova05 temporarily deployed to more-secrets January 21, 2022 09:36 Inactive

format

446244c

annalvova05 temporarily deployed to more-secrets January 21, 2022 12:51 Inactive

isort

c96dbe5

annalvova05 temporarily deployed to more-secrets January 21, 2022 14:37 Inactive

antixar approved these changes Jan 21, 2022

View reviewed changes

octavia-squidington-iii temporarily deployed to more-secrets January 21, 2022 20:25 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 21, 2022 20:39 Inactive

bump version

6414500

annalvova05 merged commit 8529928 into master Jan 21, 2022

annalvova05 deleted the alvova/7098-tiktok-oauth branch January 21, 2022 21:01

annalvova05 temporarily deployed to more-secrets January 21, 2022 21:03 Inactive

octavia-squidington-iii mentioned this pull request Jan 21, 2022

Bump Airbyte version from 0.35.6-alpha to 0.35.7-alpha #9708

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Source TikTok Marketing: support oauth flow #7636

🎉 Source TikTok Marketing: support oauth flow #7636

annalvova05 commented Nov 4, 2021 •

edited

Loading

annalvova05 commented Jan 19, 2022 •

edited by github-actions bot

Loading

antixar left a comment

antixar Jan 19, 2022

annalvova05 Jan 20, 2022

antixar left a comment

annalvova05 commented Jan 21, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Jan 21, 2022 •

edited by github-actions bot

Loading

🎉 Source TikTok Marketing: support oauth flow #7636

🎉 Source TikTok Marketing: support oauth flow #7636

Conversation

annalvova05 commented Nov 4, 2021 • edited Loading

What

How

Recommended reading order

Pre-merge Checklist

Community member or Airbyter

Airbyter

annalvova05 commented Jan 19, 2022 • edited by github-actions bot Loading

antixar left a comment

Choose a reason for hiding this comment

antixar Jan 19, 2022

Choose a reason for hiding this comment

annalvova05 Jan 20, 2022

Choose a reason for hiding this comment

antixar left a comment

Choose a reason for hiding this comment

annalvova05 commented Jan 21, 2022 • edited by github-actions bot Loading

annalvova05 commented Jan 21, 2022 • edited by github-actions bot Loading

annalvova05 commented Nov 4, 2021 •

edited

Loading

annalvova05 commented Jan 19, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Jan 21, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Jan 21, 2022 •

edited by github-actions bot

Loading