Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Zendesk Support: incorrect spec file #7097

Merged
merged 2 commits into from
Oct 18, 2021

Conversation

antixar
Copy link
Contributor

@antixar antixar commented Oct 16, 2021

What

Version 0.1.2 includes a part of non-relevant settings that can confuse end users.

How

remote it temporarily

Recommended reading order

  1. spec.json
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Maksym Pavlenok seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the area/connectors Connector related issues label Oct 16, 2021
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Oct 16, 2021
@antixar antixar temporarily deployed to more-secrets October 16, 2021 20:59 Inactive
@antixar antixar marked this pull request as ready for review October 16, 2021 21:02
@jrhizor jrhizor temporarily deployed to more-secrets October 16, 2021 21:02 Inactive
@antixar antixar requested a review from sherifnada October 16, 2021 21:02
@antixar
Copy link
Contributor Author

antixar commented Oct 16, 2021

/test connector=connectors/source-zendesk-support

🕑 connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/1349957850
✅ connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/1349957850
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  860    419    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                 Stmts   Miss  Cover
	 --------------------------------------------------------
	 source_zendesk_support/__init__.py       2      0   100%
	 source_zendesk_support/source.py        38     15    61%
	 source_zendesk_support/streams.py      275     81    71%
	 --------------------------------------------------------
	 TOTAL                                  315     96    70%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                 Stmts   Miss  Cover
	 --------------------------------------------------------
	 source_zendesk_support/__init__.py       2      0   100%
	 source_zendesk_support/source.py        38     15    61%
	 source_zendesk_support/streams.py      275    114    59%
	 --------------------------------------------------------
	 TOTAL                                  315    129    59%

@jrhizor jrhizor temporarily deployed to more-secrets October 16, 2021 21:09 Inactive
@antixar
Copy link
Contributor Author

antixar commented Oct 18, 2021

/publish connector=connectors/source-zendesk-support

🕑 connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/1353782503
✅ connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/1353782503

@jrhizor jrhizor temporarily deployed to more-secrets October 18, 2021 08:34 Inactive
@antixar antixar merged commit 4054d8b into master Oct 18, 2021
@antixar antixar deleted the antixar/zendesk-support-spec-without-oauth branch October 18, 2021 08:56
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
* remove oauth settings from spec file

* update changelog

Co-authored-by: Maksym Pavlenok <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants