Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📚 Docs Refresh: BigQuery Destination #6665

Merged
merged 9 commits into from
Oct 4, 2021
Merged

Conversation

avaidyanatha
Copy link
Contributor

Main Changes

  • Reorganization
  • Removed superfluous information
  • Formatting fixes

@avaidyanatha avaidyanatha added the area/documentation Improvements or additions to documentation label Oct 3, 2021
@avaidyanatha avaidyanatha temporarily deployed to more-secrets October 3, 2021 03:53 Inactive
@avaidyanatha avaidyanatha temporarily deployed to more-secrets October 3, 2021 03:56 Inactive
docs/integrations/destinations/bigquery.md Outdated Show resolved Hide resolved
docs/integrations/destinations/bigquery.md Outdated Show resolved Hide resolved
docs/integrations/destinations/bigquery.md Outdated Show resolved Hide resolved

The Airbyte BigQuery destination allows you to sync data to BigQuery. BigQuery is a serverless, highly scalable, and cost-effective data warehouse offered by Google Cloud Provider.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these overview one-liners are useful to keep

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The information about what BigQuery is can already be found in the description, so the overview is essentially only saying that it allows you to sync data to BigQuery... which I'm not sure is valuable.

Screen Shot 2021-10-03 at 10 50 57 PM

n

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it could be valuable keeping all of that information in the meta description, but I'm mostly concerned about organizing the index on the right and making sure the most important information is seen first.

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM small comments 🚀

@avaidyanatha avaidyanatha temporarily deployed to more-secrets October 4, 2021 05:53 Inactive
@avaidyanatha avaidyanatha merged commit bee03dc into master Oct 4, 2021
@avaidyanatha avaidyanatha deleted the abhi/large-question branch October 4, 2021 05:54
@avaidyanatha avaidyanatha temporarily deployed to more-secrets October 4, 2021 05:54 Inactive
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
* Docs Refresh: BigQuery Destination

* Add language for Cloud.

* Update docs/integrations/destinations/bigquery.md

Co-authored-by: Sherif A. Nada <[email protected]>

* Update docs/integrations/destinations/bigquery.md

Co-authored-by: Sherif A. Nada <[email protected]>

* Update docs/integrations/destinations/bigquery.md

Co-authored-by: Marcos Marx <[email protected]>

* Update docs/integrations/destinations/bigquery.md

Co-authored-by: Sherif A. Nada <[email protected]>

* Update docs/integrations/destinations/bigquery.md

Co-authored-by: Marcos Marx <[email protected]>

* Update docs/integrations/destinations/bigquery.md

Co-authored-by: Marcos Marx <[email protected]>

* Add link to GCS.

Co-authored-by: Sherif A. Nada <[email protected]>
Co-authored-by: Marcos Marx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants