Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📚 Docs Refresh: Postgres Source #6664

Merged
merged 6 commits into from
Oct 4, 2021
Merged

📚 Docs Refresh: Postgres Source #6664

merged 6 commits into from
Oct 4, 2021

Conversation

avaidyanatha
Copy link
Contributor

Main Changes

  • Cleaned up a lot of unnecessary information
  • Reorganized structure
  • Retitled sections for clarity
  • Quality of life improvements

@avaidyanatha avaidyanatha added the area/documentation Improvements or additions to documentation label Oct 3, 2021
@avaidyanatha avaidyanatha changed the title Docs Refresh: Postgres Source 📚 Docs Refresh: Postgres Source Oct 3, 2021
@avaidyanatha avaidyanatha temporarily deployed to more-secrets October 3, 2021 03:44 Inactive
@avaidyanatha avaidyanatha temporarily deployed to more-secrets October 3, 2021 04:05 Inactive
@avaidyanatha avaidyanatha temporarily deployed to more-secrets October 3, 2021 04:52 Inactive
sherifnada
sherifnada approved these changes Oct 3, 2021
View reviewed changes
docs/integrations/sources/postgres.md Outdated Show resolved Hide resolved
docs/integrations/sources/postgres.md Outdated Show resolved Hide resolved
marcosmarxm
marcosmarxm reviewed Oct 3, 2021
View reviewed changes
docs/integrations/sources/postgres.md Outdated
@@ -81,18 +11,24 @@ If you can't find the data type you are looking for or have any problems feel fr
| Logical Replication \(WAL\) | Yes | |
| SSL Support | Yes | |
| SSH Tunnel Connection | Coming soon | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not supported now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is! It just wasn't updated along with the addition of the SSH tunnel docs, updating now, thanks :)

marcosmarxm
marcosmarxm approved these changes Oct 3, 2021
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT small comment about SSH feature.

@avaidyanatha avaidyanatha merged commit e584685 into master Oct 4, 2021
@avaidyanatha avaidyanatha deleted the abhi/postmodern-gres branch October 4, 2021 05:49
@avaidyanatha avaidyanatha temporarily deployed to more-secrets October 4, 2021 05:50 Inactive
@jrhizor jrhizor mentioned this pull request Oct 4, 2021
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@avaidyanatha @sherifnada @schlattk
📚 Docs Refresh: Postgres Source (airbytehq#6664)
6dfe9f7 
* Docs Refresh: Postgres Source

* Add CDC back to the steps.

* Add note about TLS.

* Update docs/integrations/sources/postgres.md

Co-authored-by: Sherif A. Nada <[email protected]>

* Update docs/integrations/sources/postgres.md

Co-authored-by: Sherif A. Nada <[email protected]>

* Update SSH Tunnel feature.

Co-authored-by: Sherif A. Nada <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm marcosmarxm approved these changes

@sherifnada sherifnada sherifnada approved these changes

Assignees
No one assigned
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avaidyanatha @marcosmarxm @sherifnada