Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Google Search Console: correct spec.json file #6222

Merged
merged 5 commits into from
Sep 23, 2021
Merged

Source Google Search Console: correct spec.json file #6222

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d289a25
correct spec.json file
Sep 17, 2021
e2d0017
bump version
Sep 17, 2021
56cb2e6
bump version
Sep 17, 2021
57878ae
update doc for connector spec ref
Sep 22, 2021
46badf9
merge master
Sep 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ain/resources/config/STANDARD_SOURCE_DEFINITION/eb4c9e00-db83-4d63-a386-39cfa91012a8.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
"sourceDefinitionId": "eb4c9e00-db83-4d63-a386-39cfa91012a8",
"name": "Google Search Console (native)",
"dockerRepository": "airbyte/source-google-search-console",
"dockerImageTag": "0.1.0",
"dockerImageTag": "0.1.1",
"documentationUrl": "https://docs.airbyte.io/integrations/sources/google-search-console"
}
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@
- sourceDefinitionId: eb4c9e00-db83-4d63-a386-39cfa91012a8
name: Google Search Console
dockerRepository: airbyte/source-google-search-console
dockerImageTag: 0.1.0
dockerImageTag: 0.1.1
documentationUrl: https://docs.airbyte.io/integrations/sources/google-search-console
- sourceDefinitionId: bad83517-5e54-4a3d-9b53-63e85fbd4d7c
name: ClickHouse
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-google-search-console/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ RUN pip install .
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.0
LABEL io.airbyte.version=0.1.1
LABEL io.airbyte.name=airbyte/source-google-search-console
12 changes: 10 additions & 2 deletions ...tegrations/connectors/source-google-search-console/source_google_search_console/spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
"type": "object",
"oneOf": [
{
"title": "Client Auth",
"type": "object",
"required": [
"auth_type",
Expand All @@ -38,7 +39,10 @@
"properties": {
"auth_type": {
"type": "string",
"const": "Client"
"const": "Client",
"enum": ["Client"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a UI bug? pretty sure artem made it so that this format is no longer needed in the UI

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it's a UI bug. There is a video in the issue showing the problem :(

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you create a follow up issue for artem if there isn't one?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. I believe there should be some info about this in the docs, somewhere at https://docs.airbyte.io/connector-development/connector-specification-reference maybe? Could you update it?

"default": "Client",
"order": 0
},
"client_id": {
"type": "string",
Expand All @@ -59,11 +63,15 @@
},
{
"type": "object",
"title": "Service Auth",
"required": ["auth_type", "service_account_info"],
"properties": {
"auth_type": {
"type": "string",
"const": "Service"
"const": "Service",
"enum": ["Service"],
"default": "Service",
"order": 0
},
"service_account_info": {
"type": "string",
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/google-search-console.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,4 +95,5 @@ You should now be ready to use the Google Workspace Admin Reports API connector

| Version | Date | Pull Request | Subject |
| :------ | :-------- | :----- | :------ |
| `0.1.1` | 2021-09-17 | [6222](https://github.com/airbytehq/airbyte/pull/6222) | Correct Spec File |
| `0.1.0` | 2021-09-03 | [5350](https://github.com/airbytehq/airbyte/pull/5350) | Initial Release |