-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "android_last_seen_at" data type #6082
Conversation
Intercom API send a timestamp for the "android_last_seen_at" field. Which cause issue later on when dbt tries to created the table. 2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - Database Error in model intercom__contacts (models/generated/airbyte_tables/dev_sandbox/intercom__contacts.sql) 2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - Invalid digit, Value '-', Pos 4, Type: Long 2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - DETAIL: 2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - ----------------------------------------------- 2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - error: Invalid digit, Value '-', Pos 4, Type: Long 2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - code: 1207 2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - context: 2021-09-03T00:45:55Z 2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - query: 131295371 2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - location: :0 2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - process: query3_51_131295371 [pid=0] 2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - ----------------------------------------------- 2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - compiled SQL at ../build/run/airbyte_utils/models/generated/airbyte_tables/dev_sandbox/intercom__contacts.sql
Thanks! I'll review today the change :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ReptilianBrain Thanks for PR. We get the timestamp from Intercom API and in the schema, we write type integer which matches with API response. So, I didn't think we need change the schema. Could you test your issue on the last version of Intercom connector - #6087
Hello @lazebnyi Thank you for your reply. You are right the API documentation and response is giving the result as an integer. My confusion comes from when I look at the content of _airbyte_raw_intercom__contacts (using the latest version of the connector) The android_last_seen_at field data is shown as a timestamp. here's a snippet of the data I see in the table
Does this help investigating my issue ? Thank you |
@lazebnyi I tried to run Intercom with Integration Account and these fields are null so I can't validate it. Could you populate with some data to check it? @ReptilianBrain can you assign the CLA? Besides that we only need to add data to this fields and runs tests! Looks good to me! :D thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving based on user info! I'll wait @lazebnyi to merge this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumped version
@marcosmarxm need run tests and publish before merge |
/test connector=connectors/source-intercom
|
/publish connector=connectors/source-intercom
|
Intercom API send a timestamp for the "android_last_seen_at" field. Which cause issue later on when dbt tries to created the table.
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - Database Error in model intercom__contacts (models/generated/airbyte_tables/dev_sandbox/intercom__contacts.sql)
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - Invalid digit, Value '-', Pos 4, Type: Long
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - DETAIL:
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - -----------------------------------------------
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - error: Invalid digit, Value '-', Pos 4, Type: Long
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - code: 1207
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - context: 2021-09-03T00:45:55Z
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - query: 131295371
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - location: :0
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - process: query3_51_131295371 [pid=0]
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - -----------------------------------------------
2021-09-10 02:40:43 INFO () LineGobbler(voidCall):85 - compiled SQL at ../build/run/airbyte_utils/models/generated/airbyte_tables/dev_sandbox/intercom__contacts.sql
What
Describe what the change is solving
It helps to add screenshots if it affects the frontend.
How
Describe the solution
Recommended reading order
x.java
y.python
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes