🎉 New Destination: DynamoDB #5561
Conversation
Implemented getConsumer and check methods. Signed-off-by: Jinni Gu <[email protected]>
Signed-off-by: Yiqing Wang <[email protected]>
Signed-off-by: Yiqing Wang <[email protected]>
Signed-off-by: Jinni Gu <[email protected]>
Added integration tests and unit tests. Signed-off-by: qtz123 <[email protected]>
Signed-off-by: qtz123 <[email protected]>
github-actions
bot
added
area/connectors
Signed-off-by: Jinni Gu <[email protected]>
Signed-off-by: qtz123 <[email protected]>
|
thanks for the contribution @jinnig |
There was a problem hiding this comment.
LGTM! Already test locally and use with the webapp and works great! Some small comments let me know what do you think about them @jinnig
...tion-dynamodb/src/main/java/io/airbyte/integrations/destination/dynamodb/DynamodbWriter.java
Outdated
Show resolved
Hide resolved
...tion-dynamodb/src/main/java/io/airbyte/integrations/destination/dynamodb/DynamodbWriter.java
Outdated
Show resolved
Hide resolved
...db/src/main/java/io/airbyte/integrations/destination/dynamodb/DynamodbOutputTableHelper.java
Show resolved
Hide resolved
Gave the value a name batchSize. Removed unnecessary logs. Signed-off-by: Yiqing Wang <[email protected]>
| try { | ||
| PutItemOutcome outcome = table | ||
| .putItem( | ||
| new Item().withPrimaryKey(JavaBaseConstants.COLUMN_NAME_AB_ID, UUID.randomUUID().toString(), "sync_time", System.currentTimeMillis())); |
There was a problem hiding this comment.
@jinnig Dynamodb is a key-value and document database. Using the primary key as a hash type means you're focusing this connector as a document database? Or a hash type PK using in key-value for Dynamodb is not a problem?
There was a problem hiding this comment.
For now we are just using DynamoDB as a document DB to store JSON objects. However, we have discussed this topic with Shrif - see how to use getPrimaryKey() to get a primary key. Do you think the other issues have been resolved in the last commit?
What
Added AWS DynamoDB as the destination.
https://aws.amazon.com/dynamodb/
Recommended reading order
DynamodbDestination.javaDynamodbChecker.javaDynamodbConsumer.javaDynamodbWriter.javaDynamodbDestinationAcceptanceTest.javaPre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mddocs/SUMMARY.mddocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampledocs/integrations/README.mdairbyte-integrations/builds.md