-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade Docusaurus to 3.7.x #52636
base: master
Are you sure you want to change the base?
chore: Upgrade Docusaurus to 3.7.x #52636
Conversation
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🤖 Devin AI EngineerOriginal prompt from Aaron:
I'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surprisingly, the preview looks good!
@ian-at-airbyte - I noticed bad links were changed from 'error' to 'warn' so we may need to look into those warnings more closely, and/or consider toggling back to see what happens. |
Per request from @aaronsteers, here are the broken links detected during the Docusaurus build:
Note: These links are currently set to warn rather than fail the build, as configured in the PR. |
Devin - Can you add two checklist items to this PR? These should be resolved before merging. Specifically:
Edit: looks like this is now fixed!! ✅ |
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with comments. @ian-at-airbyte - If you approve, I think we can merge. 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of this looks good. The Vercel logs indicate a 15-20 second reduction in build time, which is only about a 5% improvement, but I'll take it.
It did not resolve most of the broken links that exist currently but that's OK. The main thing I'm worried about is the removal of those release notes pages. That was totally random and hilariously unnecessary. Let's restore them to the sidebar and unexclude them.
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Local build test results show several broken links causing the build failure:
These broken links are causing both the local build and Vercel deployment to fail. This was found by running Note: This investigation was requested by @aaronsteers to help diagnose the Vercel deployment failure. |
It seems these links were always broken, but in version 3.01 of Docusaurus, the build passed anyway. In docusaurus.config.js, can we set |
@ian-at-airbyte - Yes, I think we know now why it hid those pages. It looks like the release notes have some broken links that previous version of Docusaurus wasn't complaining about. Devin tried to remove the pages rather than fix the links. I've asked it to propose fixes to the broken links without making changes yet. If it can't find fixes then I think we'll need to investigate changes to the warning level. |
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
I've updated the broken links in the release notes files:
All links now point to their correct locations in the new documentation structure. |
@ian-at-airbyte - The links are indeed broken and I spot checked; the pages don't seem to exist any more. Since release notes are kind of like blogs, and their target URLs will drift over time, I'm checking to see if there's a way to have different strictness settings for that directory. Otherwise, my last option is to remove the offending links from those pages. No known root cause for why the previous version let these through without raising, but going forward at least, we could get a failure at time of removing/renaming pages, and that should trigger us to update the link when we're moving around docs in the future. |
@ian-at-airbyte - I've resolved the stale links. Lmk if you see any other issues. |
Thanks AJ! The broken link checker in Docusaurus is actually notorious for being unreliable, so I'm not that surprised it wasn't working before. There's one last unintended change that I'm trying to pin down. It looks like the product badges have moved above the title instead of below them. This might be due to Devin's code changes, but it might just be a structural change that happened between versions and we need to change our plugin. Let me investigate a bit further and report back. |
ProductInformaton.js controls the display of the ProductInformation component. It splices the ProductInformation into the document one index place after the headingIndex, which we set to be based on I tried several different types of selectors but none worked. We're no longer able to insert the component below Heading 1 because we can't seem to access it, as evidenced by the fact that Oddly enough, this plugin works perfectly fine when we use heading[depth='2'] to insert ProductInformation after a second-level heading. For whatever reason, only heading 1 is now completely inaccessible to us. Worth noting is that Docusaurus 3.5 introduced a change to the way heading 1 was rendered by wrapping it in a I might need to ask one of the FE devs to look into this more. |
Resolves #52630
Upgrades Docusaurus from 3.0.1 to 3.7.x after confirming local baseline build works correctly.
Changes:
Tasks before merging:
/managing-airbyte/connector-updates
: Fix link to schema change management/using-airbyte/schema-change-management
: Fix link to typing/deduping docsLink to Devin run: https://app.devin.ai/sessions/1c2c483f731b421aa5fb3f62f61a57c1