Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-cloudtrail: fix acceptance tests #5152

Merged
merged 3 commits into from
Aug 4, 2021
Merged

Conversation

yaroslav-dudar
Copy link
Contributor

@yaroslav-dudar yaroslav-dudar commented Aug 3, 2021

What

Fixed acceptance tests in aws-cloudtrail #5151

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

Connector checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Secrets are annotated with airbyte_secret in the connector's spec
  • Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
  • Unit & integration tests added as appropriate (and are passing)
    • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • /test connector=connectors/<name> command as documented here is passing.
    • Community members can skip this, Airbyters will run this for you.
  • Code reviews completed
  • Documentation updated
    • README.md
    • docs/SUMMARY.md if it's a new connector
    • Created or updated reference docs in docs/integrations/<source or destination>/<name>.
    • Changelog in the appropriate page in docs/integrations/.... See changelog example
    • docs/integrations/README.md contains a reference to the new connector
    • Build status added to build page
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified

Connector Generator checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added the area/connectors Connector related issues label Aug 3, 2021
@yaroslav-dudar
Copy link
Contributor Author

yaroslav-dudar commented Aug 3, 2021

/test connector=connectors/source-aws-cloudtrail

🕑 connectors/source-aws-cloudtrail https://github.com/airbytehq/airbyte/actions/runs/1093652265
✅ connectors/source-aws-cloudtrail https://github.com/airbytehq/airbyte/actions/runs/1093652265

@jrhizor jrhizor temporarily deployed to more-secrets August 3, 2021 10:56 Inactive
@@ -10,7 +10,7 @@
"aws_region_name",
"start_date"
],
"additionalProperties": false,
"additionalProperties": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are the additional fields? should we add them to the schema?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have optional config to limit amount of records to read. this allows to speedup test execution

more details here - #4122 (comment)

@midavadim
Copy link
Contributor

We should bump the connector version and update files with seeds as well.

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Aug 4, 2021
@yaroslav-dudar
Copy link
Contributor Author

yaroslav-dudar commented Aug 4, 2021

/publish connector=connectors/source-aws-cloudtrail

🕑 connectors/source-aws-cloudtrail https://github.com/airbytehq/airbyte/actions/runs/1097445149
✅ connectors/source-aws-cloudtrail https://github.com/airbytehq/airbyte/actions/runs/1097445149

@jrhizor jrhizor temporarily deployed to more-secrets August 4, 2021 11:10 Inactive
@yaroslav-dudar yaroslav-dudar marked this pull request as ready for review August 4, 2021 11:17
@yaroslav-dudar yaroslav-dudar merged commit e009416 into master Aug 4, 2021
@yaroslav-dudar yaroslav-dudar deleted the yaroslav-dudar/5151 branch August 4, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants