-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Mailchimp: fix primary key for email activities #5137
Source Mailchimp: fix primary key for email activities #5137
Conversation
/test connector=connectors/source-mailchimp
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would make sense, but it should be tested.
Vadim said, he created a separate issue, that SAT will test primary key (issue is lined above). From Connector MailChimp side, I fixed the primary key. |
…chimp_email_activity_primary_key_bugfix
/publish connector=connectors/source-mailchimp
|
What
Closes #5130
How
I was not able to reproduce the following error with our data (the sync was successful), however it looks clear. The activities have not neither the id field, neither any other unique one could be used as source defined primary key. This commit removes default "id" from this
stream and should close the following issue.
Recommended reading order
x.java
y.python
Pre-merge Checklist
Expand the checklist which is relevant for this PR.
Connector checklist
airbyte_secret
in the connector's spec./gradlew :airbyte-integrations:connectors:<name>:integrationTest
./test connector=connectors/<name>
command as documented here is passing.README.md
docs/SUMMARY.md
if it's a new connectordocs/integrations/<source or destination>/<name>
.docs/integrations/...
. See changelog exampledocs/integrations/README.md
contains a reference to the new connector/publish
command described hereConnector Generator checklist
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes