Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Mailchimp: fix primary key for email activities #5137

Conversation

vovavovavovavova
Copy link
Contributor

@vovavovavovavova vovavovavovavova commented Aug 2, 2021

What

Closes #5130

How

I was not able to reproduce the following error with our data (the sync was successful), however it looks clear. The activities have not neither the id field, neither any other unique one could be used as source defined primary key. This commit removes default "id" from this
stream and should close the following issue.

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

Connector checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Secrets are annotated with airbyte_secret in the connector's spec
  • Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
  • Unit & integration tests added as appropriate (and are passing)
    • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • /test connector=connectors/<name> command as documented here is passing.
    • Community members can skip this, Airbyters will run this for you.
  • Code reviews completed
  • Documentation updated
    • README.md
    • docs/SUMMARY.md if it's a new connector
    • Created or updated reference docs in docs/integrations/<source or destination>/<name>.
    • Changelog in the appropriate page in docs/integrations/.... See changelog example
    • docs/integrations/README.md contains a reference to the new connector
    • Build status added to build page
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified

Connector Generator checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added the area/connectors Connector related issues label Aug 2, 2021
@vovavovavovavova
Copy link
Contributor Author

vovavovavovavova commented Aug 2, 2021

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1090770817
✅ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1090770817

@jrhizor jrhizor temporarily deployed to more-secrets August 2, 2021 15:24 Inactive
@htrueman htrueman linked an issue Aug 2, 2021 that may be closed by this pull request
Copy link
Contributor

@vitaliizazmic vitaliizazmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would make sense, but it should be tested.

@vovavovavovavova
Copy link
Contributor Author

That would make sense, but it should be tested.

Vadim said, he created a separate issue, that SAT will test primary key (issue is lined above). From Connector MailChimp side, I fixed the primary key.

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Aug 3, 2021
@vovavovavovavova
Copy link
Contributor Author

vovavovavovavova commented Aug 4, 2021

/publish connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1096653984
✅ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1096653984

@jrhizor jrhizor temporarily deployed to more-secrets August 4, 2021 06:25 Inactive
@vovavovavovavova vovavovavovavova merged commit 1e45000 into master Aug 4, 2021
@vovavovavovavova vovavovavovavova deleted the valdemar/#5130_mailchimp_email_activity_primary_key_bugfix branch August 4, 2021 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
4 participants