Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't fail on test-reporter action and add comments on failures #21566

Merged
merged 1 commit into from
Jan 19, 2023
Merged

don't fail on test-reporter action and add comments on failures #21566

merged 1 commit into from
Jan 19, 2023

Conversation

c-p-b
Copy link
Contributor

@c-p-b c-p-b commented Jan 18, 2023

What

This change updates two github actions:

https://github.com/EnricoMi/publish-unit-test-result-action
https://github.com/dorny/test-reporter

The first change forces test-reporter to not fail when the build fails. The reasoning behind this change is that when the build fails, you typically want to see that. However, if test-reporter fails, that's the first thing you see when you click in, which can erroneously lead people to believe that the reporting action failed to upload, when in reality it was the build itself.

The second change updates publish-unit-test-result-action to add a pr comment pointing to specific test failures when they occur. This is to increase visibility of failures to end users.

How

Update gradle.yml

@c-p-b c-p-b requested a review from colesnodgrass January 18, 2023 23:56
@c-p-b c-p-b temporarily deployed to more-secrets January 18, 2023 23:58 — with GitHub Actions Inactive
@c-p-b c-p-b temporarily deployed to more-secrets January 18, 2023 23:58 — with GitHub Actions Inactive
@c-p-b c-p-b temporarily deployed to more-secrets January 19, 2023 00:02 — with GitHub Actions Inactive
@c-p-b c-p-b temporarily deployed to more-secrets January 19, 2023 00:02 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 26.77% 🍏

colesnodgrass
colesnodgrass approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@colesnodgrass colesnodgrass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious what this will actually look like, changes seem fine.

@c-p-b c-p-b force-pushed the junit-failure-reporting branch from 83e2127 to b5fe6b8 Compare January 19, 2023 01:27
@c-p-b c-p-b temporarily deployed to more-secrets January 19, 2023 02:03 — with GitHub Actions Inactive
@c-p-b c-p-b temporarily deployed to more-secrets January 19, 2023 02:07 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2023 •
edited
Loading

Connectors Base Test Results

   123 files  ±0     123 suites  ±0   2m 44s ⏱️ ±0s
1 095 tests ±0  1 092 ✔️ ±0  3 💤 ±0  0 ❌ ±0 
1 096 runs  ±0  1 093 ✔️ ±0  3 💤 ±0  0 ❌ ±0 

Results for commit bc4fadf. ± Comparison against base commit 9ca9d47.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2023 •
edited
Loading

Platform Test Results

   231 files     231 suites   25m 54s ⏱️
1 606 tests 1 596 ✔️ 10 💤 0 ❌
1 626 runs  1 616 ✔️ 10 💤 0 ❌

Results for commit bc4fadf.

♻️ This comment has been updated with latest results.

@c-p-b c-p-b force-pushed the junit-failure-reporting branch from b5fe6b8 to bc4fadf Compare January 19, 2023 18:37
@c-p-b c-p-b enabled auto-merge (squash) January 19, 2023 18:38
@c-p-b c-p-b temporarily deployed to more-secrets January 19, 2023 18:40 — with GitHub Actions Inactive
@c-p-b c-p-b temporarily deployed to more-secrets January 19, 2023 18:42 — with GitHub Actions Inactive
@c-p-b c-p-b merged commit 96e16a8 into master Jan 19, 2023
@c-p-b c-p-b deleted the junit-failure-reporting branch January 19, 2023 19:26
etsybaev pushed a commit that referenced this pull request Jan 19, 2023
@etsybaev
don't fail on test-reporter action and add comments on failures (#21566)
540ceb0
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesnodgrass colesnodgrass colesnodgrass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c-p-b @colesnodgrass