Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating start-aws-runner-action to fetch the latest AMI #21475

Merged

Conversation

Mykyta-Serbynevskyi
Copy link
Contributor

In scope of https://github.com/airbytehq/airbyte-cloud/issues/3612 a new process of AMI building was introduced.
This PR updates start-aws-runner-action to fetch the latest freshest AMI in AWS for gh self-hosted runners.

@Mykyta-Serbynevskyi Mykyta-Serbynevskyi requested review from a team January 17, 2023 10:27
@Mykyta-Serbynevskyi Mykyta-Serbynevskyi self-assigned this Jan 17, 2023
@Mykyta-Serbynevskyi Mykyta-Serbynevskyi temporarily deployed to more-secrets January 17, 2023 10:35 — with GitHub Actions Inactive
@Mykyta-Serbynevskyi Mykyta-Serbynevskyi temporarily deployed to more-secrets January 17, 2023 10:35 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 26.59% 🍏

Copy link
Contributor

@supertopher supertopher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great Mykyta. Did we test this beforehand or are we testing in prod?

even if we have tested this I want to keep an eye in prod since I imagine if this fails it's going to cause alot of drama.

ty

@Mykyta-Serbynevskyi
Copy link
Contributor Author

this looks great Mykyta. Did we test this beforehand or are we testing in prod?

even if we have tested this I want to keep an eye in prod since I imagine if this fails it's going to cause alot of drama.

Yes, it has been tested by checks in this PR and they are all green.

Moreover, I can see those checks used the freshest AMI that had been created via Build AMI gh workflow in airbyte-cloud repo:

https://github.com/airbytehq/airbyte/actions/runs/3938364826/jobs/6736973450#step:4:53

Thus there should not be any issues.
Anyway, I will keep an eye on this for a while.

@Mykyta-Serbynevskyi Mykyta-Serbynevskyi merged commit 2b4f0aa into master Jan 18, 2023
@Mykyta-Serbynevskyi Mykyta-Serbynevskyi deleted the mserbynevskyi/3612-update-start-aws-runner-action branch January 18, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants