Fix connector builder link once more #21442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iv
added
the
area/documentation
|
Closing because this issue was magically resolved on the docs page |
sherifnada
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The fix I described in #21441 still did not work once actually deployed to the docs page, even though again it worked locally.
How
./understanding-the-yaml-file/yaml-overviewresulted in navigating tohttps://docs.airbyte.com/connector-development/config-based/connector-builder-ui/understanding-the-yaml-file/yaml-overviewon docs.airbyte.com, and../config-based/understanding-the-yaml-file/yaml-overviewresulted in navigating tohttps://docs.airbyte.com/connector-development/config-based/config-based/understanding-the-yaml-file/yaml-overviewon docs.airbyte.com.Both of those approaches properly navigated to the desired url of
http://localhost:3000/connector-development/config-based/understanding-the-yaml-file/yaml-overviewwhen testing locally 🤷However, the approach of omitting the
./and/or../completely seems to work for other relative links pointing to similar sibling folders in this readme (e.g. here), so I am trying that approach here as well. It works locally and the similar link works both locally and on docs.airbyte.com, so I feel fairly confident about this solution.