Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connector builder: Fix record scrolling #21392

Merged
merged 4 commits into from
Jan 18, 2023
Merged

Conversation

flash1293
Copy link
Contributor

Fixes a small layouting issue from #21154 with the pagination being shown behind the records if they need to scroll causing them to be not clickable:

Before:
Screenshot 2023-01-13 at 15 24 23

After:
Screenshot 2023-01-13 at 15 24 16

@octavia-squidington-iv octavia-squidington-iv added the area/frontend Related to the Airbyte webapp label Jan 13, 2023
@flash1293 flash1293 marked this pull request as ready for review January 13, 2023 18:23
@flash1293 flash1293 requested a review from lmossman January 17, 2023 11:38
@lmossman
Copy link
Contributor

@flash1293 it's a little bit unrelated to this PR, but I pushed up this small change to set the size of the tab text in the testing panel to xs, because I felt that the tab text was too big now.
Feel free to revert if you disagree: f073d1c

Before:
Screen Shot 2023-01-17 at 1 36 27 PM

After:
Screen Shot 2023-01-17 at 1 36 15 PM

Copy link
Contributor

@lmossman lmossman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, tested locally and it fixes the issue

@flash1293 flash1293 merged commit 3dea132 into master Jan 18, 2023
@flash1293 flash1293 deleted the flash1293/fix-pagination branch January 18, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp team/extensibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants