Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAT: check future_state only for incremental streams. #21248

Merged
merged 4 commits into from
Jan 13, 2023

Conversation

grubberr
Copy link
Contributor

@grubberr grubberr commented Jan 11, 2023

Signed-off-by: Sergey Chvalyuk [email protected]

What

  • in test_strictness_level="high" incremental block check that all streams in configured_catalog_path has to be in future_state file. I have improved to check only incremental streams (not all streams)
  • add sleep for test_connector_config_path_fixture test to avoid side-effect when 2 files created with the same ctime

How

Describe the solution

@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2023

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

  • Run integration tests
  • Bump connector or module version
  • Add changelog
  • Publish the new version

✅ Sources (63)

Connector Version Changelog Publish
source-airtable 1.0.1
source-amazon-ads 0.1.27
source-amazon-seller-partner 0.2.30
source-amazon-sqs 0.1.0
source-amplitude 0.1.19
source-appsflyer 0.1.0
source-asana 0.1.5
source-azure-table 0.1.3
source-braintree 0.1.3
source-cart 0.2.0
source-chargebee 0.1.16
source-commercetools 0.1.0
source-confluence 0.1.1
source-datadog 0.1.0
source-delighted 0.2.0
source-drift 0.2.5
source-facebook-marketing 0.2.82
source-freshcaller 0.1.0
source-freshsales 0.1.2
source-freshservice 0.1.1
source-github 0.3.11
source-gitlab 0.1.12
source-google-ads 0.2.7
source-google-search-console 0.1.18
source-greenhouse 0.3.0
source-harvest 0.1.14
source-instagram 1.0.0
source-iterable 0.1.22
source-klaviyo 0.1.10
source-lemlist 0.1.1
source-lever-hiring 0.1.3
source-linnworks 0.1.5
source-mailchimp 0.3.1
source-mailgun 0.1.0
source-monday 0.2.2
source-notion 1.0.0
source-okta 0.1.14
source-onesignal 0.1.2
source-openweather 0.1.6
source-outreach 0.1.2
source-pardot 0.1.1
source-paystack 0.1.1
source-pinterest 0.2.1
source-pipedrive 0.1.13
source-plaid 0.3.2
source-posthog 0.1.8
source-prestashop 0.3.0
source-quickbooks-singer 0.1.5
source-recharge 0.2.4
source-retently 0.1.3
source-salesforce 1.0.29
source-salesloft 0.1.3
source-sendgrid 0.2.16
source-sentry 0.1.8
source-strava 0.1.2
source-surveymonkey 0.1.13
source-tplcentral 0.1.1
source-twilio 0.1.14
source-weatherstack 0.1.0
source-youtube-analytics 0.1.3
source-zendesk-sunshine 0.1.1
source-zendesk-talk 0.1.5
source-zenloop 0.1.4
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (0)

Connector Version Changelog Publish
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Other Modules (0)

Actionable Items

(click to expand)

Category Status Actionable Item
Version
mismatch
The version of the connector is different from its normal variant. Please bump the version of the connector.

doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
Changelog
doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.

changelog missing
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish
not in seed
The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.

diff seed version
The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version.

Signed-off-by: Sergey Chvalyuk <[email protected]>
@grubberr
Copy link
Contributor Author

/test connector=bases/source-acceptance-test

@grubberr grubberr changed the title SAT: future_state_fixture test only for incremental streams SAT: check future_state only for incremental streams. Jan 11, 2023
@grubberr grubberr self-assigned this Jan 11, 2023
@grubberr
Copy link
Contributor Author

grubberr commented Jan 11, 2023

/test connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/3894048646
✅ bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/3894048646
No Python unittests run

Build Passed

Test summary info:

All Passed

Signed-off-by: Sergey Chvalyuk <[email protected]>
@grubberr
Copy link
Contributor Author

grubberr commented Jan 11, 2023

/test connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/3894796710
✅ bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/3894796710
No Python unittests run

Build Passed

Test summary info:

All Passed

@grubberr
Copy link
Contributor Author

@alafanechere Can you please look in this PR?
I have changed code to check abnormal_state file only for streams which support incremental

Copy link
Contributor

@alafanechere alafanechere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this improvement!
Do you know how to publish a new SAT version? Let me know if you want me to publish it.

@grubberr
Copy link
Contributor Author

@alafanechere I have seen in another PRs how to do it, thank you for help

@grubberr
Copy link
Contributor Author

grubberr commented Jan 13, 2023

/publish connector=bases/source-acceptance-test auto-bump-version=false

🕑 Publishing the following connectors:
bases/source-acceptance-test
https://github.com/airbytehq/airbyte/actions/runs/3911969837


Connector Did it publish? Were definitions generated?
bases/source-acceptance-test

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@grubberr grubberr merged commit 81be661 into master Jan 13, 2023
@grubberr grubberr deleted the grubberr/sat-fix-incremental-strictness-level-high branch January 13, 2023 14:21
jbfbell pushed a commit that referenced this pull request Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants