-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the persistence activity to use the new persistence layer #14205
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
62bd6ee
Change the persistence activity to use the new persistence layer
benmoriceau 77a11f0
Use lombok
benmoriceau 09ef89f
format
benmoriceau 5041401
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/use…
benmoriceau 80cf85c
Use new State message helper
benmoriceau 48e4df7
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/use…
benmoriceau File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60 changes: 60 additions & 0 deletions
60
airbyte-workers/src/test/java/io/airbyte/workers/temporal/sync/PersistStateActivityTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
/* | ||
* Copyright (c) 2022 Airbyte, Inc., all rights reserved. | ||
*/ | ||
|
||
package io.airbyte.workers.temporal.sync; | ||
|
||
import com.fasterxml.jackson.databind.JsonNode; | ||
import io.airbyte.commons.features.FeatureFlags; | ||
import io.airbyte.commons.json.Jsons; | ||
import io.airbyte.config.StandardSyncOutput; | ||
import io.airbyte.config.State; | ||
import io.airbyte.config.StateWrapper; | ||
import io.airbyte.config.persistence.StatePersistence; | ||
import java.io.IOException; | ||
import java.util.UUID; | ||
import org.elasticsearch.common.collect.Map; | ||
import org.junit.jupiter.api.Test; | ||
import org.junit.jupiter.api.extension.ExtendWith; | ||
import org.mockito.InjectMocks; | ||
import org.mockito.Mock; | ||
import org.mockito.Mockito; | ||
import org.mockito.junit.jupiter.MockitoExtension; | ||
|
||
@ExtendWith(MockitoExtension.class) | ||
public class PersistStateActivityTest { | ||
|
||
private final static UUID CONNECTION_ID = UUID.randomUUID(); | ||
|
||
@Mock | ||
StatePersistence statePersistence; | ||
|
||
@Mock | ||
FeatureFlags featureFlags; | ||
|
||
@InjectMocks | ||
PersistStateActivityImpl persistStateActivity; | ||
|
||
@Test | ||
public void testPersistEmpty() { | ||
persistStateActivity.persist(CONNECTION_ID, new StandardSyncOutput()); | ||
|
||
Mockito.verifyNoInteractions(statePersistence); | ||
} | ||
|
||
@Test | ||
public void testPersist() throws IOException { | ||
Mockito.when(featureFlags.useStreamCapableState()).thenReturn(true); | ||
|
||
final JsonNode jsonState = Jsons.jsonNode(Map.ofEntries( | ||
Map.entry("some", "state"))); | ||
|
||
final State state = new State().withState(jsonState); | ||
|
||
persistStateActivity.persist(CONNECTION_ID, new StandardSyncOutput().withState(state)); | ||
|
||
// The ser/der of the state into a state wrapper is tested in StateMessageHelperTest | ||
Mockito.verify(statePersistence).updateOrCreateState(Mockito.eq(CONNECTION_ID), Mockito.any(StateWrapper.class)); | ||
} | ||
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes that could have been avoided but it is a good occasion to do a cleanup