Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-shopify: Inconsistent Comparison Fix #13163

Closed
wants to merge 3 commits into from
Closed

source-shopify: Inconsistent Comparison Fix #13163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
45b10da
:hammer: incosistent comparison fixed
ahmed-buksh May 25, 2022
2ff086a
:zap: docker file updated along with docs
ahmed-buksh May 25, 2022
b45daf4
change default value to epoch ts string
alafanechere May 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-shopify/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,5 @@ COPY source_shopify ./source_shopify
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.37
LABEL io.airbyte.version=0.1.38
LABEL io.airbyte.name=airbyte/source-shopify
4 changes: 3 additions & 1 deletion airbyte-integrations/connectors/source-shopify/source_shopify/source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,9 @@ def filter_records_newer_than_state(self, stream_state: Mapping[str, Any] = None
# Getting records >= state
if stream_state:
for record in records_slice:
if record.get(self.cursor_field, "") >= stream_state.get(self.cursor_field):
if record.get(self.cursor_field, "1970-01-01T00:00:00+00:00") >= stream_state.get(
self.cursor_field, "1970-01-01T00:00:00+00:00"
):
yield record
else:
yield from records_slice
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/shopify.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ This is expected when the connector hits the 429 - Rate Limit Exceeded HTTP Erro

| Version | Date | Pull Request | Subject |
|:--------| :--- | :--- | :--- |
| 0.1.38 | 2022-05-25 | [13163](https://github.com/airbytehq/airbyte/pull/13163) | Fix inconsistent comparison |
| 0.1.37 | 2022-04-30 | [12500](https://github.com/airbytehq/airbyte/pull/12500) | Improve input configuration copy |
| 0.1.36 | 2022-03-22 | [9850](https://github.com/airbytehq/airbyte/pull/9850) | Added `BalanceTransactions` stream |
| 0.1.35 | 2022-03-07 | [10915](https://github.com/airbytehq/airbyte/pull/10915) | Fix a bug which caused `full-refresh` syncs of child REST entities configured for `incremental` |
Expand Down