Add confirmation modal when navigating away from unsaved source or destination settings #12186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/frontend
area/platform
…ation settings pages Add routes to destinations and source settings pages Ensure ServiceForm is reset with updated values on successful save
edmundito
force-pushed
the
src-dest-settings-confirm
branch
from
930c595 to
17280f7
Compare
Closed
teallarson
approved these changes
Apr 21, 2022
There was a problem hiding this comment.
This is an extension of some of the work done in #11831 correct? Seems helpful to link the two or link back to the issue.
Looks good to me, cleans up some things, and works locally. 👍
suhomud
pushed a commit
that referenced
this pull request
May 23, 2022
…ation settings pages (#12186) Add routes to destinations and source settings pages Ensure ServiceForm is reset with updated values on successful save
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add a "discard changes" confirmation modal when navigating away from the Source and Destination settings pages
How
This uses the form tracking service to monitor changes to the form on the service pages and display the modal when the form is dirty.
Additionally, it adds routes to the settings pages instead of being based on a React state.
Recommended reading order
Top to bottom