-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Mailchimp: fix campaign's stream normalization #10975
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10975 +/- ##
=========================================
Coverage ? 50.00%
=========================================
Files ? 3
Lines ? 150
Branches ? 0
=========================================
Hits ? 75
Misses ? 75
Partials ? 0 Continue to review full report at Codecov.
|
/test connector=connectors/source-mailchimp
|
@bazarnov do you know why the tests are failing here? |
I believe there is a mismatch between two sequential reads (full-refresh sync), please, merge with master and try again. So, try again, in the first place. |
/test connector=connectors/source-mailchimp
|
/publish connector=connectors/source-mailchimp
|
What
Resolves #8825
How
The smallest possible fix I could test locally implies removing a "type" definition within the campaign's stream jsonschema.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described here