Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Mailchimp: fix campaign's stream normalization #10975

Merged
merged 5 commits into from
Mar 23, 2022

Conversation

arimbr
Copy link
Contributor

@arimbr arimbr commented Mar 9, 2022

What

Resolves #8825

How

The smallest possible fix I could test locally implies removing a "type" definition within the campaign's stream jsonschema.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@CLAassistant
Copy link

CLAassistant commented Mar 9, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the area/connectors Connector related issues label Mar 9, 2022
@arimbr arimbr requested a review from ChristopheDuong March 9, 2022 11:26
@arimbr arimbr self-assigned this Mar 9, 2022
@arimbr arimbr changed the title 🐛 Source Mailchimp: fix campaigns stream normalization failing 🐛 Source Mailchimp: fix campaign's stream normalization failing Mar 9, 2022
@arimbr arimbr changed the title 🐛 Source Mailchimp: fix campaign's stream normalization failing 🐛 Source Mailchimp: fix campaign's stream normalization Mar 9, 2022
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@e07f12d). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #10975   +/-   ##
=========================================
  Coverage          ?   50.00%           
=========================================
  Files             ?        3           
  Lines             ?      150           
  Branches          ?        0           
=========================================
  Hits              ?       75           
  Misses            ?       75           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e07f12d...9327a8f. Read the comment docs.

@arimbr arimbr temporarily deployed to more-secrets March 9, 2022 20:45 Inactive
@arimbr arimbr temporarily deployed to more-secrets March 9, 2022 20:46 Inactive
@arimbr
Copy link
Contributor Author

arimbr commented Mar 9, 2022

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1959893573
❌ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1959893573
🐛 https://gradle.com/s/lk2j7os5sj4bu
Python short test summary info:

=========================== short test summary info ============================
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs1]
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
============= 1 failed, 37 passed, 1 skipped in 1532.27s (0:25:32) =============

@arimbr
Copy link
Contributor Author

arimbr commented Mar 16, 2022

@bazarnov do you know why the tests are failing here?

@bazarnov
Copy link
Collaborator

@bazarnov do you know why the tests are failing here?

I believe there is a mismatch between two sequential reads (full-refresh sync), please, merge with master and try again.
If it fails one more time, don't worry - try again. Sometimes when the data is updated frequently on the resource, in this case Mailchimp, this tests are failed because there is a mismatch between two reads, they should be equal, or the first one should be a subset (non mutable) from the second one.

So, try again, in the first place.

@arimbr
Copy link
Contributor Author

arimbr commented Mar 16, 2022

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1994816676
✅ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/1994816676
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                           Stmts   Miss  Cover
--------------------------------------------------
source_mailchimp/__init__.py       2      0   100%
source_mailchimp/source.py        45     14    69%
source_mailchimp/streams.py      103     61    41%
--------------------------------------------------
TOTAL                            150     75    50%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 38 passed, 1 skipped in 1640.57s (0:27:20) ==================

@arimbr
Copy link
Contributor Author

arimbr commented Mar 17, 2022

/publish connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/2000627570
✅ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/2000627570

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Mar 17, 2022
@arimbr arimbr temporarily deployed to more-secrets March 17, 2022 21:23 Inactive
@arimbr arimbr temporarily deployed to more-secrets March 17, 2022 21:23 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Mailchimp: AssertionError: Mismatched number of tables
5 participants