-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Source FB Marketing: add time_increment
parameter to custom insight streams
#10531
Conversation
|
Codecov Report
@@ Coverage Diff @@
## master #10531 +/- ##
=========================================
Coverage ? 89.80%
=========================================
Files ? 11
Lines ? 834
Branches ? 0
=========================================
Hits ? 749
Misses ? 85
Partials ? 0 Continue to review full report at Codecov.
|
…add-time-increment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@keu added some wording suggestions. Thanks for adding the description!
airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/spec.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/spec.py
Outdated
Show resolved
Hide resolved
…ce_facebook_marketing/spec.py Co-authored-by: Sherif A. Nada <[email protected]>
…ce_facebook_marketing/spec.py Co-authored-by: Sherif A. Nada <[email protected]>
/publish connector=connectors/source-facebook-marketing
|
/publish connector=connectors/source-facebook-marketing
|
What
closing #6225
How
When we slice date intervals it is important to stick to the start point -
start_date
.This is why we define three new parameters on the custom insight level:
start_date
with default to globalstart_date
end_date
with default to globalend_date
time_increment
with default1
, and maximum to90
🚨 User Impact 🚨
No
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described here