Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source FB Marketing: add time_increment parameter to custom insight streams #10531

Merged
merged 36 commits into from
Mar 8, 2022

Conversation

keu
Copy link
Contributor

@keu keu commented Feb 22, 2022

What

closing #6225

How

When we slice date intervals it is important to stick to the start point - start_date.
This is why we define three new parameters on the custom insight level:

  • start_date with default to global start_date
  • end_date with default to global end_date
  • time_increment with default 1, and maximum to 90

🚨 User Impact 🚨

No

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@CLAassistant
Copy link

CLAassistant commented Feb 22, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ keu
❌ eugene-kulak
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Feb 22, 2022
@keu keu self-assigned this Feb 22, 2022
@keu keu temporarily deployed to more-secrets February 22, 2022 09:07 Inactive
@keu keu temporarily deployed to more-secrets February 22, 2022 09:07 Inactive
@keu keu temporarily deployed to more-secrets February 22, 2022 11:18 Inactive
@keu keu temporarily deployed to more-secrets February 22, 2022 11:18 Inactive
@keu keu temporarily deployed to more-secrets February 22, 2022 11:26 Inactive
@keu keu temporarily deployed to more-secrets February 22, 2022 11:26 Inactive
@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@d39b636). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 0b29bc0 differs from pull request most recent head 51bdf66. Consider uploading reports for the commit 51bdf66 to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10531   +/-   ##
=========================================
  Coverage          ?   89.80%           
=========================================
  Files             ?       11           
  Lines             ?      834           
  Branches          ?        0           
=========================================
  Hits              ?      749           
  Misses            ?       85           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d39b636...51bdf66. Read the comment docs.

@keu keu temporarily deployed to more-secrets February 22, 2022 12:55 Inactive
@keu keu temporarily deployed to more-secrets February 22, 2022 12:55 Inactive
@keu keu temporarily deployed to more-secrets February 22, 2022 13:54 Inactive
@keu keu temporarily deployed to more-secrets February 22, 2022 13:54 Inactive
@keu keu temporarily deployed to more-secrets February 22, 2022 14:46 Inactive
@keu keu temporarily deployed to more-secrets March 1, 2022 06:12 Inactive
@keu keu temporarily deployed to more-secrets March 1, 2022 06:12 Inactive
@keu keu temporarily deployed to more-secrets March 3, 2022 14:48 Inactive
@keu keu temporarily deployed to more-secrets March 3, 2022 14:48 Inactive
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keu added some wording suggestions. Thanks for adding the description!

…ce_facebook_marketing/spec.py

Co-authored-by: Sherif A. Nada <[email protected]>
@keu keu temporarily deployed to more-secrets March 4, 2022 13:53 Inactive
@keu keu temporarily deployed to more-secrets March 4, 2022 13:53 Inactive
…ce_facebook_marketing/spec.py

Co-authored-by: Sherif A. Nada <[email protected]>
@keu keu temporarily deployed to more-secrets March 5, 2022 08:06 Inactive
@keu keu temporarily deployed to more-secrets March 5, 2022 08:06 Inactive
@keu keu temporarily deployed to more-secrets March 5, 2022 08:21 Inactive
@keu keu temporarily deployed to more-secrets March 5, 2022 08:21 Inactive
@keu
Copy link
Contributor Author

keu commented Mar 6, 2022

/publish connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1942335931
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1942335931

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets March 6, 2022 21:09 Inactive
@keu keu temporarily deployed to more-secrets March 8, 2022 08:04 Inactive
@keu keu temporarily deployed to more-secrets March 8, 2022 08:04 Inactive
@keu
Copy link
Contributor Author

keu commented Mar 8, 2022

/publish connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1950335081
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1950335081

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets March 8, 2022 08:33 Inactive
@keu keu merged commit 2932039 into master Mar 8, 2022
@keu keu deleted the keu/6225-source-fb-add-time-increment branch March 8, 2022 14:31
@keu keu temporarily deployed to more-secrets March 8, 2022 14:33 Inactive
@keu keu temporarily deployed to more-secrets March 8, 2022 14:33 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Facebook Marketing: Allow user to set time_increment parameter for Insights API
6 participants