Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Shopify: add tender_transactions stream #10449

Merged
merged 9 commits into from
Feb 21, 2022

Conversation

bazarnov
Copy link
Collaborator

What

Resolving: #10448

How

  • added tender_transactions stream

🚨 User Impact 🚨

Update the connector, if Customer needs this data.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@bazarnov bazarnov self-assigned this Feb 18, 2022
@github-actions github-actions bot added the area/connectors Connector related issues label Feb 18, 2022
@bazarnov bazarnov linked an issue Feb 18, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@1e0ac30). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10449   +/-   ##
=========================================
  Coverage          ?   71.42%           
=========================================
  Files             ?        5           
  Lines             ?      406           
  Branches          ?        0           
=========================================
  Hits              ?      290           
  Misses            ?      116           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e0ac30...869bbc7. Read the comment docs.

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Feb 18, 2022
@bazarnov bazarnov temporarily deployed to more-secrets February 18, 2022 12:26 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets February 18, 2022 12:26 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets February 18, 2022 12:29 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets February 18, 2022 12:29 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 18, 2022 12:47 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 21, 2022 09:05 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets February 21, 2022 10:02 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets February 21, 2022 10:02 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 21, 2022 10:03 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets February 21, 2022 11:21 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets February 21, 2022 11:21 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 21, 2022 11:24 Inactive
@bazarnov
Copy link
Collaborator Author

bazarnov commented Feb 21, 2022

/test connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1875914321
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1875914321
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/tests/test_incremental.py        69     38    45%
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_shopify/__init__.py        2      0   100%
source_shopify/auth.py           20      4    80%
source_shopify/source.py        272    103    62%
source_shopify/transform.py      58      3    95%
source_shopify/utils.py          58      6    90%
-------------------------------------------------
TOTAL                           410    116    72%

@bazarnov bazarnov temporarily deployed to more-secrets February 21, 2022 11:40 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets February 21, 2022 11:40 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 21, 2022 11:40 Inactive
Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please publish your changes

@bazarnov bazarnov temporarily deployed to more-secrets February 21, 2022 15:51 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets February 21, 2022 15:52 Inactive
@bazarnov
Copy link
Collaborator Author

bazarnov commented Feb 21, 2022

/publish connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1877301604
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1877301604

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 21, 2022 16:34 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets February 21, 2022 18:07 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets February 21, 2022 18:07 Inactive
@bazarnov bazarnov merged commit 67b7fc9 into master Feb 21, 2022
@bazarnov bazarnov deleted the bazarnov/shopify-add-tender-transactions branch February 21, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🎉 Source Shopify: Implement 'tender_transactions' stream
3 participants