🐛 Source Chargebee: add tests + fix broken `coupon` stream #10366

Zirochkaa · 2022-02-16T00:15:46Z

What

Closes #10192 and #10447.

How

Add tests to /unit_tests folder.
Send correct request parameter for sorting for coupon stream.

🚨 User Impact 🚨

Are there any breaking changes?
No.

Pre-merge Checklist

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Zirochkaa · 2022-02-16T00:16:05Z

/test connector=connectors/source-chargebee

🕑 connectors/source-chargebee https://github.com/airbytehq/airbyte/actions/runs/1850129809
❌ connectors/source-chargebee https://github.com/airbytehq/airbyte/actions/runs/1850129809
🐛 https://gradle.com/s/y42jowyf65yqo

codecov · 2022-02-16T00:19:17Z

Codecov Report

❗ No coverage uploaded for pull request base (master@ce5c007). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head e399272 differs from pull request most recent head 475b5cb. Consider uploading reports for the commit 475b5cb to get more accurate results

@@            Coverage Diff            @@
##             master   #10366   +/-   ##
=========================================
  Coverage          ?   85.18%           
=========================================
  Files             ?        4           
  Lines             ?      189           
  Branches          ?        0           
=========================================
  Hits              ?      161           
  Misses            ?       28           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce5c007...475b5cb. Read the comment docs.

Zirochkaa · 2022-02-18T08:52:50Z

/test connector=connectors/source-chargebee

🕑 connectors/source-chargebee https://github.com/airbytehq/airbyte/actions/runs/1863452302
❌ connectors/source-chargebee https://github.com/airbytehq/airbyte/actions/runs/1863452302
🐛 https://gradle.com/s/rzjztr6gey6yw

Zirochkaa · 2022-02-18T09:09:09Z

/test connector=connectors/source-chargebee

🕑 connectors/source-chargebee https://github.com/airbytehq/airbyte/actions/runs/1863524238
❌ connectors/source-chargebee https://github.com/airbytehq/airbyte/actions/runs/1863524238
🐛 https://gradle.com/s/eskkh3tnj33iw

Zirochkaa · 2022-02-18T09:42:02Z

SAT:

Unit tests:

Fix `coupon` stream. Add unit tests.

Zirochkaa · 2022-02-21T14:22:49Z

/test connector=connectors/source-chargebee

🕑 connectors/source-chargebee https://github.com/airbytehq/airbyte/actions/runs/1876682489
✅ connectors/source-chargebee https://github.com/airbytehq/airbyte/actions/runs/1876682489
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                                Stmts   Miss  Cover
-------------------------------------------------------
source_chargebee/source.py             25      0   100%
source_chargebee/__init__.py            2      0   100%
source_chargebee/streams.py           143     21    85%
source_chargebee/rate_limiting.py      19      7    63%
-------------------------------------------------------
TOTAL                                 189     28    85%

Zirochkaa · 2022-02-22T07:51:49Z

/test connector=connectors/source-chargebee

🕑 connectors/source-chargebee https://github.com/airbytehq/airbyte/actions/runs/1880285446
✅ connectors/source-chargebee https://github.com/airbytehq/airbyte/actions/runs/1880285446
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                                Stmts   Miss  Cover
-------------------------------------------------------
source_chargebee/source.py             25      0   100%
source_chargebee/__init__.py            2      0   100%
source_chargebee/streams.py           143     21    85%
source_chargebee/rate_limiting.py      19      7    63%
-------------------------------------------------------
TOTAL                                 189     28    85%

airbyte-integrations/connectors/source-chargebee/unit_tests/test_source.py

Zirochkaa · 2022-02-22T08:03:26Z

/publish connector=connectors/source-chargebee

🕑 connectors/source-chargebee https://github.com/airbytehq/airbyte/actions/runs/1880328975
✅ connectors/source-chargebee https://github.com/airbytehq/airbyte/actions/runs/1880328975

Zirochkaa self-assigned this Feb 16, 2022

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Feb 16, 2022

Zirochkaa temporarily deployed to more-secrets February 16, 2022 00:16 Inactive

Zirochkaa temporarily deployed to more-secrets February 16, 2022 00:17 Inactive

octavia-squidington-iii temporarily deployed to more-secrets February 16, 2022 00:18 Inactive

Zirochkaa mentioned this pull request Feb 18, 2022

Publish PR 10269: new stream coupon for chargebee connector #10329

Merged

40 tasks

Zirochkaa linked an issue Feb 18, 2022 that may be closed by this pull request

Source Chargebee: coupon stream is broken #10447

Closed

Zirochkaa changed the title ~~Source Chargebee: add tests~~ 🐛 Source Chargebee: add tests + fix broken coupon stream Feb 18, 2022

Zirochkaa force-pushed the oleh/10192-add-tests-chargebee branch from 19de85e to 54cc3fb Compare February 18, 2022 08:52

Zirochkaa temporarily deployed to more-secrets February 18, 2022 08:54 Inactive

octavia-squidington-iii temporarily deployed to more-secrets February 18, 2022 08:55 Inactive

Zirochkaa force-pushed the oleh/10192-add-tests-chargebee branch from 54cc3fb to e712969 Compare February 18, 2022 09:09

Zirochkaa temporarily deployed to more-secrets February 18, 2022 09:10 Inactive

octavia-squidington-iii temporarily deployed to more-secrets February 18, 2022 09:11 Inactive

Zirochkaa requested review from htrueman, yevhenii-ldv and sergei-solonitcyn February 18, 2022 19:00

10192 Fix Chargebee source

3337b84

Fix `coupon` stream. Add unit tests.

Zirochkaa force-pushed the oleh/10192-add-tests-chargebee branch from e712969 to 3337b84 Compare February 21, 2022 14:22

Zirochkaa temporarily deployed to more-secrets February 21, 2022 14:24 Inactive

octavia-squidington-iii temporarily deployed to more-secrets February 21, 2022 14:25 Inactive

10192 Update tests + update docs

e399272

Zirochkaa temporarily deployed to more-secrets February 22, 2022 07:52 Inactive

sergei-solonitcyn approved these changes Feb 22, 2022

View reviewed changes

airbyte-integrations/connectors/source-chargebee/unit_tests/test_source.py Outdated Show resolved Hide resolved

octavia-squidington-iii temporarily deployed to more-secrets February 22, 2022 07:54 Inactive

octavia-squidington-iii temporarily deployed to more-secrets February 22, 2022 08:05 Inactive

10192 Bump connector's version

475b5cb

Zirochkaa merged commit e23c29d into master Feb 22, 2022

Zirochkaa deleted the oleh/10192-add-tests-chargebee branch February 22, 2022 08:20

Zirochkaa temporarily deployed to more-secrets February 22, 2022 08:22 Inactive

octavia-squidington-iii mentioned this pull request Feb 22, 2022

Bump Airbyte version from 0.35.32-alpha to 0.35.33-alpha #10546

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Source Chargebee: add tests + fix broken `coupon` stream #10366

🐛 Source Chargebee: add tests + fix broken `coupon` stream #10366

Zirochkaa commented Feb 16, 2022 •

edited

Loading

Zirochkaa commented Feb 16, 2022 •

edited by github-actions bot

Loading

codecov bot commented Feb 16, 2022 •

edited

Loading

Zirochkaa commented Feb 18, 2022 •

edited by github-actions bot

Loading

Zirochkaa commented Feb 18, 2022 •

edited by github-actions bot

Loading

Zirochkaa commented Feb 18, 2022

Zirochkaa commented Feb 21, 2022 •

edited by github-actions bot

Loading

Zirochkaa commented Feb 22, 2022 •

edited by github-actions bot

Loading

Zirochkaa commented Feb 22, 2022 •

edited by github-actions bot

Loading

🐛 Source Chargebee: add tests + fix broken coupon stream #10366

🐛 Source Chargebee: add tests + fix broken coupon stream #10366

Conversation

Zirochkaa commented Feb 16, 2022 • edited Loading

What

How

🚨 User Impact 🚨

Pre-merge Checklist

Zirochkaa commented Feb 16, 2022 • edited by github-actions bot Loading

codecov bot commented Feb 16, 2022 • edited Loading

Codecov Report

Zirochkaa commented Feb 18, 2022 • edited by github-actions bot Loading

Zirochkaa commented Feb 18, 2022 • edited by github-actions bot Loading

Zirochkaa commented Feb 18, 2022

Zirochkaa commented Feb 21, 2022 • edited by github-actions bot Loading

Zirochkaa commented Feb 22, 2022 • edited by github-actions bot Loading

Zirochkaa commented Feb 22, 2022 • edited by github-actions bot Loading

🐛 Source Chargebee: add tests + fix broken `coupon` stream #10366

🐛 Source Chargebee: add tests + fix broken `coupon` stream #10366

Zirochkaa commented Feb 16, 2022 •

edited

Loading

Zirochkaa commented Feb 16, 2022 •

edited by github-actions bot

Loading

codecov bot commented Feb 16, 2022 •

edited

Loading

Zirochkaa commented Feb 18, 2022 •

edited by github-actions bot

Loading

Zirochkaa commented Feb 18, 2022 •

edited by github-actions bot

Loading

Zirochkaa commented Feb 21, 2022 •

edited by github-actions bot

Loading

Zirochkaa commented Feb 22, 2022 •

edited by github-actions bot

Loading

Zirochkaa commented Feb 22, 2022 •

edited by github-actions bot

Loading