Connector versions are rolled back after Airbyte server is upgraded

[tuliren]

Enviroment

• Airbyte version: example is 0.29.15-alpha, 0.29.17-alpha
• OS Version / Instance:
• Deployment:
• Source Connector and version: Stripe 0.1.16, rolled back to 0.1.14
• Severity: Medium
• Step where error happened: Upgrade Airbyte

Current Behavior

After upgrading to Airbyte 0.29.15-alpha or 0.29.17-alpha, stripe (among with many other source and destination connectors), rolled back to 0.1.14.

Expected Behavior

Connector definition stays the same or get upgraded to the latest version when Airbyte is upgraded.

Logs

Slack thread: https://airbytehq.slack.com/archives/C019WJFR1JT/p1631118720129400

LOG

Steps to Reproduce

Are you willing to submit a PR?

Yes.

[tuliren]

Need to add more logging during connector definition upgrade to debug this.

[tuliren]

Oh, currently the db config persistence checks if a connector definition is in use by querying StandardSync records. However, it should query SourceConnection and DestinationConnection. That's definitely a bug.

But even if it is not getting the used connectors correctly, no connector should be rolled back. So the root cause is still a mystery.

[tuliren]

Also investigate if it is possible for a connector definition to get removed from the database. Slack thread.