fix: ensure --values settings override internal defaults
#64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colesnodgrass
changed the title
--values settings override internal defaults
bgroff
approved these changes
Jul 29, 2024
|
Tested the merge changes with a values file overriding the auth.enabled field and things look good. |
perangel
reviewed
Jul 30, 2024
| for _, s := range slice { | ||
| // s is going to be in the format of | ||
| // a.b.c=xyz | ||
| parts := strings.SplitN(s, "=", 2) |
There was a problem hiding this comment.
Is this going to cause any issues if the value contains = as in a base64 encoded string (e.g. DEADBEEF==)? Would you mind adding a test case for that
There was a problem hiding this comment.
No, this is why I am using SplitN with 2, so it will only split on the first =.
If the key was base64 encoded, then that would be a problem.
perangel
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
abctldefines certain helm values differently then their default values in Airbyte's helm charts. Specifically increasing theglobal.jobs.resource.limitsvalues, as increasing these values improves sync performance significantly in comparison to docker-compose on resource rich machines.The idea was that users could override any value defined in the helm charts or in
abctlby specifying a--valuesflag. Unfortunately this was not the case, the values withinabctlwere overriding any values provided by the--valuesflag.To fix this, this PR now treats these internal overrides as a separate
values.ymlfile (that only exists in memory) and will now overlay the user defined--valueson top of it, ensuring that the user defined--valuesalways takes higher priority.Summary
--values.ymlalways wins