Add int8 (since gdal 3.7.0) #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentvaroquauxads
force-pushed
the
add_int8
branch
5 times, most recently
from
d1b6f40 to
11e1971
Compare
Pull Request Test Coverage Report for Build 9779195638Details
💛 - Coveralls |
|
Unfortunately, I did not find a way to have a compile-time error iif Int8 is used with Gdal < 3.7.0. It will result in a runtime error. |
vincentvaroquauxads
force-pushed
the
add_int8
branch
from
11e1971 to
4137d35
Compare
Pull Request Test Coverage Report for Build 9888791533Details
💛 - Coveralls |
tbonfort
reviewed
Jul 11, 2024
doc_test.go
Outdated
| @@ -289,6 +289,19 @@ func Example_rasterTutorial() { | |||
| poDstDS.Bands()[0].Write(0, 0, abyRaster, 512, 512) | |||
| poDstDS.Close() | |||
|
|
|||
| poDstDSInt8, err := godal.Create(godal.GTiff, pszDstFilename, 1, godal.Int8, 512, 512) | |||
There was a problem hiding this comment.
Please put this test inside a new function in godal_test.go. doc_test.go is meant for documenting basic usage
godal.h
Outdated
| @@ -25,6 +25,10 @@ | |||
|
|
|||
| #if GDAL_VERSION_NUM < 3000000 | |||
| #error "this code is only compatible with gdal version >= 3.0" | |||
| #elif GDAL_VERSION_NUM < GDAL_COMPUTE_VERSION(3, 7, 0) | |||
There was a problem hiding this comment.
I would prefer if this went into its own #if instead of this #elif, as the intent is different
vincentvaroquauxads
force-pushed
the
add_int8
branch
from
4137d35 to
e255643
Compare
tbonfort
reviewed
Jul 11, 2024
Co-authored-by: Thomas Bonfort <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.